search

insightsengineering / teal.modules.clinical

Provides teal modules for the standard clinical trials outputs
https://insightsengineering.github.io/teal.modules.clinical/
Other
32 stars 17 forks source link

tm_t_summary, numeric_stats parameter issue #541

Closed donyunardi closed 1 year ago

donyunardi commented 2 years ago

Hello Team, need to report several findings:

  1. the parameter only takes value of 1L which means user can only choose one numeric statictic. However, by default, multiple statistics are selected (n, mean_sd, median, range). Shouldn't numeric_stats parameter allows more than one statistic? https://github.com/insightsengineering/teal.modules.clinical/blob/e225371a7cc9c5eb27fad06798747a06f19862c7/R/tm_t_summary.R#L290

  2. The parameter is not being used in the module. This line hard-code the selected numeric statistic to be used in the shiny app. https://github.com/insightsengineering/teal.modules.clinical/blob/e225371a7cc9c5eb27fad06798747a06f19862c7/R/tm_t_summary.R#L374 No matter what I pass in numeric_stats, it always shows the default. Shouldn't this line use the numeric_stats parameter?

Per discussion with @kumamiao, tagging @shajoezhu

edelarua commented 1 year ago

Closed by https://github.com/insightsengineering/teal.modules.clinical/pull/771