deprecation in `tidyr` looms

chlebowa commented 7 months ago

This example code in teal.modules.general.R

df <- data.frame(x = c("A", "B", "C", "A"), y = c("Z", "Z", "W", "W"))
ggplot(df) + ggmosaic::geom_mosaic(aes(x = ggmosaic::product(x), fill = y))

raises this warning.

Warning message:
`unite_()` was deprecated in tidyr 1.2.0.
ℹ Please use `unite()` instead.
ℹ The deprecated feature was likely used in the ggmosaic package.
  Please report the issue at <https://github.com/haleyjeppson/ggmosaic>.
This warning is displayed once every 8 hours.
Call `lifecycle::last_lifecycle_warnings()` to see where this warning was generated.

ggmosaic is 0.3.3, the latest version.

We should probably keep an eye on this.

averissimo commented 7 months ago

Corrected in development version for around 2 years (https://github.com/haleyjeppson/ggmosaic/issues/68)

That package needs a new release!

chlebowa commented 7 months ago

Interesting https://github.com/haleyjeppson/ggmosaic/issues/68

insightsengineering / teal.modules.general

deprecation in `tidyr` looms #662