search

insightsengineering / teal.modules.general

General Purpose Teal Modules
https://insightsengineering.github.io/teal.modules.general/
Other
9 stars 13 forks source link

Remove the internal function `var_labels` in favour of `teal.data::col_labels` #690

Closed vedhav closed 8 months ago

vedhav commented 8 months ago

Closes #689

github-actions[bot] commented 8 months ago

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  -----------------------------------------------
R/tm_a_pca.R                    825     825  0.00%    111-1060
R/tm_a_regression.R             716     716  0.00%    139-938
R/tm_data_table.R               177     177  0.00%    91-317
R/tm_file_viewer.R              172     172  0.00%    42-244
R/tm_front_page.R               129     118  8.53%    66-210
R/tm_g_association.R            332     332  0.00%    130-521
R/tm_g_bivariate.R              655     495  24.43%   192-773, 821, 827, 831, 942, 959, 977, 997-1019
R/tm_g_distribution.R          1028    1028  0.00%    121-1271
R/tm_g_response.R               351     351  0.00%    139-554
R/tm_g_scatterplot.R            719     719  0.00%    236-1046
R/tm_g_scatterplotmatrix.R      280     261  6.79%    163-460, 514, 528
R/tm_missing_data.R            1054    1054  0.00%    87-1280
R/tm_outliers.R                 976     976  0.00%    132-1238
R/tm_t_crosstable.R             254     254  0.00%    134-426
R/tm_variable_browser.R         820     815  0.61%    86-1314
R/utils.R                       100     100  0.00%    72-300
R/zzz.R                           1       1  0.00%    2
TOTAL                          8589    8394  2.27%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
R/utils.R       -22     -22  +100.00%
TOTAL           -22     -22  +0.01%

Results for commit: 5e345fec00cc5861f7312e261a0ace205472fa7c

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 8 months ago

Unit Tests Summary

 1 files   5 suites   0s :stopwatch: 16 tests 16 :white_check_mark: 0 :zzz: 0 :x: 49 runs  49 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 5e345fec.

m7pr commented 8 months ago

I appreciate every commit with negative line balance

Should this be our motto ;) ?

chlebowa commented 8 months ago

What happened to this? https://github.com/insightsengineering/teal.modules.general/pull/673

m7pr commented 8 months ago

@vedhav you did it to main. This change was already on pre-release@main lol

vedhav commented 8 months ago

🤦🏽 Sorry, I did not know about this. I should have checked the pre-release branch before I did this.

chlebowa commented 8 months ago

Pay attention, please.