search

insightsengineering / teal.modules.general

General Purpose Teal Modules
https://insightsengineering.github.io/teal.modules.general/
Other
9 stars 13 forks source link

Store the user selections so our default selection logic can be applied #699

Closed vedhav closed 8 months ago

vedhav commented 8 months ago

Closes #682

github-actions[bot] commented 8 months ago

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  --------------------------------------
R/tm_a_pca.R                    825     825  0.00%    111-1060
R/tm_a_regression.R             777     777  0.00%    153-1034
R/tm_data_table.R               177     177  0.00%    91-317
R/tm_file_viewer.R              172     172  0.00%    42-244
R/tm_front_page.R               129     118  8.53%    66-210
R/tm_g_association.R            332     332  0.00%    130-521
R/tm_g_bivariate.R              665     493  25.86%   192-773, 836, 947, 964, 982, 1002-1024
R/tm_g_distribution.R          1028    1028  0.00%    121-1271
R/tm_g_response.R               351     351  0.00%    139-554
R/tm_g_scatterplot.R            719     719  0.00%    236-1046
R/tm_g_scatterplotmatrix.R      280     261  6.79%    163-460, 514, 528
R/tm_missing_data.R            1054    1054  0.00%    87-1280
R/tm_outliers.R                 977     977  0.00%    132-1240
R/tm_t_crosstable.R             254     254  0.00%    134-426
R/tm_variable_browser.R         824     819  0.61%    86-1320
R/utils.R                       100     100  0.00%    72-300
R/zzz.R                           1       1  0.00%    2
TOTAL                          8665    8458  2.39%

Diff against main

Filename                   Stmts    Miss  Cover
-----------------------  -------  ------  -------
R/tm_variable_browser.R       +4      +4  -0.00%
TOTAL                         +4      +4  -0.00%

Results for commit: 4cacdb88a08ac345aa3ceb715048c5d63b702439

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 8 months ago

Unit Tests Summary

 1 files   5 suites   0s :stopwatch: 16 tests 16 :white_check_mark: 0 :zzz: 0 :x: 49 runs  49 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 4cacdb88.

:recycle: This comment has been updated with latest results.

kartikeyakirar commented 8 months ago

@vedhav solution looks clean, and didn't add complexity as anticipated. I have small suggestions to make it more concise.

vedhav commented 8 months ago

Thanks @kartikeyakirar I've applied the suggestions :) Now it's simpler.