insightsengineering / teal.modules.general

General Purpose Teal Modules
https://insightsengineering.github.io/teal.modules.general/
Other
9 stars 13 forks source link

using teal.data datasets to cut package size #705

Closed gogonzo closed 8 months ago

gogonzo commented 8 months ago

This addresses CRAN comments about size of the package. See R CMD build to compare sizes. Datasets used in examples are taken from teal.data

kartikeyakirar commented 8 months ago

@gogonzo The images in the vignettes directory are larger than the data. Shouldn't we reduce their size or remove it ?

image

image

gogonzo commented 8 months ago

@gogonzo The images in the vignettes directory are larger than the data. Shouldn't we reduce their size or remove it ?

image

image

I guess images are better compressed by R CMD build - after removing data package size cut from 4.8MB to <1MB. Can you confirm size of the tar.gz before my commit and after?

I can also remove images if @donyunardi is fine with it.

chlebowa commented 8 months ago

I guess images are better compressed by R CMD build - after removing data package size cut from 4.8MB to <1MB. Can you confirm size of the tar.gz before my commit and after?

How?? The .rda files are < 1 MB.

gogonzo commented 8 months ago

How?? The .rda files are < 1 MB.

Sorry, my mistake. This is how it looks like (no-images means no-images and no-data)

Skärmavbild 2024-03-04 kl  09 01 19
chlebowa commented 8 months ago

I am getting 4.0 MB on the current state of this branch. 4.6 MB on release-candidate-v0.3.0.

gogonzo commented 8 months ago

Closing this as @donyunardi has already resubmitted a package with cut size.

chlebowa commented 8 months ago

Removing the datasets from tmg and using ones from teal.data makes sense anyway. I suggest merging this.

gogonzo commented 8 months ago

Removing the datasets from tmg and using ones from teal.data makes sense anyway. I suggest merging this.

@donyunardi has already submitted the package. If they reject for some reason I can resurrect this PR