insightsengineering / teal.modules.general

General Purpose Teal Modules
https://insightsengineering.github.io/teal.modules.general/
Other
9 stars 13 forks source link

712 - `{shinytest2}` for `tm_data_table` #719

Closed kartikeyakirar closed 7 months ago

kartikeyakirar commented 7 months ago

Part of https://github.com/insightsengineering/teal.modules.general/issues/712

- [ ] testing table caption (DT functionality)

github-actions[bot] commented 7 months ago

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------
R/tm_a_pca.R                    833     833  0.00%    108-1074
R/tm_a_regression.R             779     779  0.00%    153-1037
R/tm_data_table.R               184     184  0.00%    93-330
R/tm_file_viewer.R              172     172  0.00%    44-250
R/tm_front_page.R               132     121  8.33%    70-226
R/tm_g_association.R            336     336  0.00%    135-543
R/tm_g_bivariate.R              674     412  38.87%   308-775, 816, 927, 944, 962, 973-995
R/tm_g_distribution.R          1056    1056  0.00%    122-1317
R/tm_g_response.R               352     352  0.00%    154-579
R/tm_g_scatterplot.R            728     728  0.00%    230-1059
R/tm_g_scatterplotmatrix.R      284     265  6.69%    165-478, 539, 553
R/tm_missing_data.R            1063    1063  0.00%    92-1311
R/tm_outliers.R                 991     991  0.00%    134-1269
R/tm_t_crosstable.R             257     257  0.00%    141-446
R/tm_variable_browser.R         829     824  0.60%    79-1069, 1107-1291
R/utils.R                        99      96  3.03%    82-267
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          8771    8471  3.42%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: c76d5b76727aeac1306f6bf933b62ab58a7ed47e

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 7 months ago

Unit Tests Summary

  1 files   15 suites   5m 42s :stopwatch:  76 tests  76 :white_check_mark: 0 :zzz: 0 :x: 272 runs  272 :white_check_mark: 0 :zzz: 0 :x:

Results for commit c76d5b76.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 7 months ago

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_data_table 👶 $+17.11$ $+10$ $0$ $0$ $0$
shinytest2-tm_g_scatterplot 💔 $71.77$ $+1.33$ $0$ $0$ $0$ $0$
shinytest2-tm_outliers 💔 $81.67$ $+1.70$ $0$ $0$ $0$ $0$
shinytest2-tm_variable_browser 💔 $46.18$ $+1.92$ $0$ $0$ $0$ $0$
Additional test case details | Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | shinytest2-tm_data_table | 👶 | | $+3.85$ | e2e_tm_data_table_Initializes_without_errors | | shinytest2-tm_data_table | 👶 | | $+3.93$ | e2e_tm_data_table_Verify_checkbox_displayed_over_data_table | | shinytest2-tm_data_table | 👶 | | $+4.56$ | e2e_tm_data_table_Verify_default_variable_selection_and_set_new_selection | | shinytest2-tm_data_table | 👶 | | $+4.77$ | e2e_tm_data_table_Verify_module_displays_data_table | | shinytest2-tm_variable_browser | 💔 | $7.73$ | $+1.18$ | e2e_tm_variable_browser_Selecting_treat_variable_as_factor_changes_the_table_headers |

Results for commit 35876a7d366ccf1efa1f87165f4ccb3b35802144

♻️ This comment has been updated with latest results.

m7pr commented 7 months ago

@kartikeyakirar I left you 3 comments

kartikeyakirar commented 7 months ago

@m7pr there is error on distinct row check . fixed it here 391902e