search

insightsengineering / teal.modules.general

General Purpose Teal Modules
https://insightsengineering.github.io/teal.modules.general/
Other
9 stars 13 forks source link

712 - `{shinytest2}` for `tm_g_bivariate` #720

Closed vedhav closed 7 months ago

vedhav commented 7 months ago

Part of #712

m7pr commented 7 months ago

Hey @vedhav I left you a few comments + requested your review on https://github.com/insightsengineering/teal.modules.general/pull/718 so that maybe you can see what other things can be tested besides just using app$get_active_module_input()

m7pr commented 7 months ago

@vedhav I think there is a lot of ggplot:: prefixing that is missing in R/tm_g_bivariate.R - I do experience issues when testing R/tm_g_association.R

m7pr commented 7 months ago

It was only one : 58686eecd51b2c6c2a81d87257b6a37955327c32

vedhav commented 7 months ago

I added the prefixes now. I think you committed the changes in your branch by mistake @m7pr

github-actions[bot] commented 7 months ago

Unit Tests Summary

  1 files   16 suites   6m 56s :stopwatch:  80 tests  80 :white_check_mark: 0 :zzz: 0 :x: 316 runs  316 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 90ab7eda.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 7 months ago

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_g_bivariate 👶 $+43.12$ $+44$ $0$ $0$ $0$
shinytest2-tm_g_scatterplot 💔 $73.87$ $+25.02$ $0$ $0$ $0$ $0$
Additional test case details | Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | shinytest2-tm_g_bivariate | 👶 | | $+6.20$ | e2e_tm_g_bivariate_coloring_options_are_hidden_when_coloring_is_toggled_off | | shinytest2-tm_g_bivariate | 👶 | | $+6.18$ | e2e_tm_g_bivariate_facetting_options_are_hidden_when_facet_is_toggled_off | | shinytest2-tm_g_bivariate | 👶 | | $+6.11$ | e2e_tm_g_bivariate_module_is_initialised_with_the_specified_defaults | | shinytest2-tm_g_bivariate | 👶 | | $+24.64$ | e2e_tm_g_bivariate_setting_encoding_inputs_produces_outputs_without_validation_errors | | shinytest2-tm_g_scatterplot | 💔 | $7.10$ | $+25.09$ | e2e_tm_g_scatterplot_module_is_initialised_with_the_specified_defaults |

Results for commit 235d88d2e6b8c7030e044ad68fe1511f383398b8

♻️ This comment has been updated with latest results.

github-actions[bot] commented 7 months ago

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------
R/tm_a_pca.R                    833     833  0.00%    108-1074
R/tm_a_regression.R             779     779  0.00%    153-1037
R/tm_data_table.R               184     184  0.00%    93-330
R/tm_file_viewer.R              172     172  0.00%    44-250
R/tm_front_page.R               132     121  8.33%    70-226
R/tm_g_association.R            336     336  0.00%    135-543
R/tm_g_bivariate.R              678     416  38.64%   303-775, 816, 927, 944, 962, 973-995
R/tm_g_distribution.R          1056    1056  0.00%    122-1317
R/tm_g_response.R               352     352  0.00%    154-579
R/tm_g_scatterplot.R            728     728  0.00%    230-1059
R/tm_g_scatterplotmatrix.R      284     265  6.69%    165-478, 539, 553
R/tm_missing_data.R            1063    1063  0.00%    92-1311
R/tm_outliers.R                 991     991  0.00%    134-1269
R/tm_t_crosstable.R             257     257  0.00%    141-446
R/tm_variable_browser.R         829     824  0.60%    79-1069, 1107-1291
R/utils.R                        99      96  3.03%    82-267
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          8775    8475  3.42%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  -------
R/tm_g_bivariate.R       +4      +4  -0.23%
TOTAL                    +4      +4  -0.00%

Results for commit: 90ab7eda02763be4a7369be4b97167caf953e1be

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

m7pr commented 7 months ago

@vedhav I needed to commit them in my branch becuase I am partially testing the same set of functions as you do

m7pr commented 7 months ago

@averissimo besides this comment https://github.com/insightsengineering/teal.modules.general/pull/720/files#r1565844323 I think we are ready to go. Would you be able to update this PR?

m7pr commented 7 months ago

I actually did that here 8a5b7cbf7b18ec4e67c578ca2885329ce4c4bc94

m7pr commented 7 months ago

Do we need tests for color, fill and size parameters?

image