search

insightsengineering / teal.modules.general

General Purpose Teal Modules
https://insightsengineering.github.io/teal.modules.general/
Other
9 stars 13 forks source link

712 - `{shinytest2}` for `tm_g_association` #722

Closed m7pr closed 7 months ago

m7pr commented 7 months ago

Part of #712

github-actions[bot] commented 7 months ago

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------
R/tm_a_pca.R                    833     833  0.00%    108-1074
R/tm_a_regression.R             779     779  0.00%    153-1037
R/tm_data_table.R               184     184  0.00%    93-330
R/tm_file_viewer.R              172     172  0.00%    44-250
R/tm_front_page.R               132     121  8.33%    70-226
R/tm_g_association.R            336     336  0.00%    135-543
R/tm_g_bivariate.R              674     412  38.87%   308-775, 816, 927, 944, 962, 973-995
R/tm_g_distribution.R          1056    1056  0.00%    122-1317
R/tm_g_response.R               352     352  0.00%    154-579
R/tm_g_scatterplot.R            728     728  0.00%    230-1059
R/tm_g_scatterplotmatrix.R      284     265  6.69%    165-478, 539, 553
R/tm_missing_data.R            1063    1063  0.00%    92-1311
R/tm_outliers.R                 991     991  0.00%    134-1269
R/tm_t_crosstable.R             257     257  0.00%    141-446
R/tm_variable_browser.R         829     824  0.60%    79-1069, 1107-1291
R/utils.R                        99      96  3.03%    82-267
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          8771    8471  3.42%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: fd1b50d99937e0a9b43e1dbcfdc0d4269115c925

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 7 months ago

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_g_association 👶 $+28.79$ $+13$ $0$ $0$ $0$
Additional test case details | Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | shinytest2-tm_g_association | 👶 | | $+7.82$ | e2e_tm_g_association_data_extract_spec_elements_are_initialized_with_the_default_values_specified_by_ref_and_vars_arguments | | shinytest2-tm_g_association | 👶 | | $+7.09$ | e2e_tm_g_association_data_parameter_and_module_label_is_passed_properly | | shinytest2-tm_g_association | 👶 | | $+5.63$ | e2e_tm_g_association_module_plot_is_visible | | shinytest2-tm_g_association | 👶 | | $+8.25$ | e2e_tm_g_association_test_if_default_radio_buttons_are_checked |

Results for commit 1fe49b81cf9945fb79f5c163dd22ea98371ec64e

♻️ This comment has been updated with latest results.

github-actions[bot] commented 7 months ago

Unit Tests Summary

  1 files    8 suites   1m 16s :stopwatch:  39 tests  39 :white_check_mark: 0 :zzz: 0 :x: 104 runs  104 :white_check_mark: 0 :zzz: 0 :x:

Results for commit fd1b50d9.

:recycle: This comment has been updated with latest results.

m7pr commented 7 months ago

Weird, locally I see tests passing

> options(TESTING_DEPTH = 5)
> devtools::test()
ℹ Testing teal.modules.general
✔ | F W  S  OK | Context
✔ |         14 | shinytest2-tm_g_association [15.6s]                   
✔ |         18 | tm_g_bivariate                                        
✔ |         21 | bivariate_ggplot_call                                 
✔ |          4 | front_page                                            
✔ |         15 | g_expert_cl                                           
✔ |          6 | scatterplotmatrix_get_stats                           
✔ |          3 | variable_browser                                      

══ Results ════════════════════════════════════════════════════════════
Duration: 16.2 s

[ FAIL 0 | WARN 0 | SKIP 0 | PASS 81 ]
m7pr commented 7 months ago

Added app$wait_for_idle() in 3 places

m7pr commented 7 months ago

checks are passing now

m7pr commented 7 months ago

Thanks for the review @kartikeyakirar

m7pr commented 7 months ago

@kartikeyakirar thanks for the review, I did push few changes as you suggested. Would you mind taking one more look?

kartikeyakirar commented 7 months ago

@m7pr minor suggestion. rest looks good

m7pr commented 7 months ago

Thanks @kartikeyakirar just approved suggestions. Feeling powerful enough to accept / approve the PR : ) ?