search

insightsengineering / teal.modules.general

General Purpose Teal Modules
https://insightsengineering.github.io/teal.modules.general/
Other
9 stars 13 forks source link

712 - `{shinytest2}` for `tm_missing_data` #727

Closed kartikeyakirar closed 7 months ago

kartikeyakirar commented 7 months ago

Part of https://github.com/insightsengineering/teal.modules.general/issues/712

github-actions[bot] commented 7 months ago

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------
R/tm_a_pca.R                    833     833  0.00%    108-1074
R/tm_a_regression.R             779     779  0.00%    153-1037
R/tm_data_table.R               184     184  0.00%    93-330
R/tm_file_viewer.R              172     172  0.00%    44-250
R/tm_front_page.R               132     121  8.33%    70-226
R/tm_g_association.R            336     336  0.00%    135-543
R/tm_g_bivariate.R              678     416  38.64%   303-775, 816, 927, 944, 962, 973-995
R/tm_g_distribution.R          1056    1056  0.00%    122-1317
R/tm_g_response.R               352     352  0.00%    154-579
R/tm_g_scatterplot.R            728     728  0.00%    230-1059
R/tm_g_scatterplotmatrix.R      284     265  6.69%    165-478, 539, 553
R/tm_missing_data.R            1075    1075  0.00%    92-1323
R/tm_outliers.R                 991     991  0.00%    134-1269
R/tm_t_crosstable.R             257     257  0.00%    141-446
R/tm_variable_browser.R         829     824  0.60%    79-1069, 1107-1291
R/utils.R                        99      96  3.03%    82-267
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          8787    8487  3.41%

Diff against main

Filename               Stmts    Miss  Cover
-------------------  -------  ------  --------
R/tm_missing_data.R      +12     +12  +100.00%
TOTAL                    +12     +12  -0.00%

Results for commit: 6b7b203e4e5fc1724971a9f3464127590147bc26

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 7 months ago

Unit Tests Summary

  1 files   18 suites   7m 51s :stopwatch:  88 tests  88 :white_check_mark: 0 :zzz: 0 :x: 363 runs  363 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 6b7b203e.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 7 months ago

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_misssing_data 👶 $+32.12$ $+26$ $0$ $0$ $0$
shinytest2-tm_outliers 💔 $82.57$ $+1.24$ $0$ $0$ $0$ $0$
Additional test case details | Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | shinytest2-tm_misssing_data | 👶 | | $+7.61$ | e2e_tm_missing_data_Check_default_settings_and_visibility_of_the_combinations_graph_and_encodings | | shinytest2-tm_misssing_data | 👶 | | $+6.97$ | e2e_tm_missing_data_Default_settings_and_visibility_of_the_summary_graph | | shinytest2-tm_misssing_data | 👶 | | $+4.77$ | e2e_tm_missing_data_Initializes_without_errors | | shinytest2-tm_misssing_data | 👶 | | $+5.70$ | e2e_tm_missing_data_Validate_By_Variable_Levels_table_values | | shinytest2-tm_misssing_data | 👶 | | $+7.07$ | e2e_tm_missing_data_Validate_functionality_and_UI_response_for_By_Variable_Levels_ |

Results for commit f8697b07e9af06544f6baafe4dff26f969bdc488

♻️ This comment has been updated with latest results.

m7pr commented 7 months ago

hey @kartikeyakirar - just left you the first version of comments

kartikeyakirar commented 7 months ago

@m7pr thanks for the review. Accepted all the suggestions.