insightsengineering / teal.modules.general

General Purpose Teal Modules
https://insightsengineering.github.io/teal.modules.general/
Other
9 stars 13 forks source link

712 - `{shinytest2}` for `tm_t_crosstable` #733

Closed kartikeyakirar closed 7 months ago

kartikeyakirar commented 7 months ago

Part of https://github.com/insightsengineering/teal.modules.general/issues/712

github-actions[bot] commented 7 months ago

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------
R/tm_a_pca.R                    833     833  0.00%    108-1074
R/tm_a_regression.R             779     779  0.00%    153-1037
R/tm_data_table.R               184     184  0.00%    93-330
R/tm_file_viewer.R              172     172  0.00%    44-250
R/tm_front_page.R               132     121  8.33%    70-226
R/tm_g_association.R            336     336  0.00%    135-543
R/tm_g_bivariate.R              678     416  38.64%   303-775, 816, 927, 944, 962, 973-995
R/tm_g_distribution.R          1056    1056  0.00%    122-1317
R/tm_g_response.R               352     352  0.00%    154-579
R/tm_g_scatterplot.R            728     728  0.00%    230-1059
R/tm_g_scatterplotmatrix.R      284     265  6.69%    165-478, 539, 553
R/tm_missing_data.R            1075    1075  0.00%    92-1323
R/tm_outliers.R                 991     991  0.00%    134-1269
R/tm_t_crosstable.R             257     257  0.00%    141-446
R/tm_variable_browser.R         829     824  0.60%    79-1069, 1107-1291
R/utils.R                        99      96  3.03%    82-267
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          8787    8487  3.41%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 498dab0039cc7b21f2c1bbb6340827f3a604609e

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 7 months ago

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_file_viewer 💚 $19.65$ $-2.82$ $0$ $0$ $0$ $0$
shinytest2-tm_g_association 💚 $29.10$ $-1.74$ $0$ $0$ $0$ $0$
shinytest2-tm_g_bivariate 💚 $44.35$ $-1.78$ $0$ $0$ $0$ $0$
shinytest2-tm_outliers 💚 $85.32$ $-2.82$ $0$ $0$ $0$ $0$
shinytest2-tm_t_crosstable 👶 $+26.64$ $+9$ $0$ $0$ $0$
shinytest2-tm_variable_browser 💚 $49.54$ $-2.61$ $0$ $0$ $0$ $0$
Additional test case details | Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | shinytest2-tm_file_viewer | 💚 | $5.41$ | $-1.09$ | e2e_tm_file_viewer_Shows_selected_url | | shinytest2-tm_g_bivariate | 💚 | $25.14$ | $-1.02$ | e2e_tm_g_bivariate_setting_encoding_inputs_produces_outputs_without_validation_errors | | shinytest2-tm_t_crosstable | 👶 | | $+6.95$ | e2e_tm_t_crosstable_Change_plot_settings | | shinytest2-tm_t_crosstable | 👶 | | $+5.84$ | e2e_tm_t_crosstable_Initializes_without_errors | | shinytest2-tm_t_crosstable | 👶 | | $+8.16$ | e2e_tm_t_crosstable_Verify_default_values_and_settings_data_extracts_for_data_selection | | shinytest2-tm_t_crosstable | 👶 | | $+5.70$ | e2e_tm_t_crosstable_Verify_module_displays_data_table |

Results for commit 0729afeb3a93ca7db674fc658566ab2f5e4cc302

♻️ This comment has been updated with latest results.

github-actions[bot] commented 7 months ago

Unit Tests Summary

  1 files   19 suites   8m 17s :stopwatch:  92 tests  92 :white_check_mark: 0 :zzz: 0 :x: 372 runs  372 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 498dab00.

:recycle: This comment has been updated with latest results.

m7pr commented 7 months ago

@kartikeyakirar your app_driver_tm_t_crosstable function is missing teal.transform:: prefixes (and maybe teal.widgets:: if you use ggplot2_args

kartikeyakirar commented 7 months ago

@kartikeyakirar your app_driver_tm_t_crosstable function is missing teal.transform:: prefixes (and maybe teal.widgets:: if you use ggplot2_args

done 94cb2f1

m7pr commented 7 months ago

One issue

  Loading required package: teal.transform
  [ FAIL 1 | WARN 5 | SKIP 0 | PASS 366 ]

  ══ Failed tests ════════════════════════════════════════════════════════════════
  ── Failure ('test-shinytest2-tm_misssing_data.R:112:3'): e2e - tm_missing_data: Check default settings and visibility of the combinations graph and encodings ──
  app_driver$get_active_module_input("iris-combination_cutoff") not equal to 2L.
  1/1 mismatches
  [1] 1 - 2 == -1
kartikeyakirar commented 7 months ago

I am not sure what's happening there. The default value for app_driver$get_active_module_input("iris-combination_cutoff") is 2, and the checks passed here https://github.com/insightsengineering/teal.modules.general/pull/727. 🤔