Closed averissimo closed 6 months ago
āā1 filesāāā22 suitesāāā10m 42s :stopwatch: 147 testsā147 :white_check_mark:ā0 :zzz:ā0 :x: 478 runsāā478 :white_check_mark:ā0 :zzz:ā0 :x:
Results for commit 67392cd8.
:recycle: This comment has been updated with latest results.
Test Suite | $Status$ | Time on main |
$Ā±Time$ | $Ā±Tests$ | $Ā±Skipped$ | $Ā±Failures$ | $Ā±Errors$ |
---|---|---|---|---|---|---|---|
shinytest2-tm_variable_browser | š | $47.98$ | $+1.78$ | $0$ | $0$ | $0$ | $0$ |
Results for commit d8739f84d1aab8821f1b7a2f8cfd61175b12c6f6
ā»ļø This comment has been updated with latest results.
This looks good. I two comments:
runtime: shiny
is required. I actually have no idea what it doesrlang
) have you considered rlang::is_interactive()
. This is the function I have discovered quite recently and I don't know whether this is really better than the one from base.runtime: shiny
- can you please check whether
runtime: shiny
is required. I actually have no idea what it does
BLUF: It's not necessary and it does nothing in this case. I'm removing it.
rlang::is_interactive()
- (assuming we already depend on
rlang
) have you consideredrlang::is_interactive()
. This is the function I have discovered quite recently and I don't know whether this is really better than the one from base.
No practical benefits here, but rlang::is_interactive()
is technically better as it will detect the right context . Unlike, base::interactive
that only detects if there is an interactive session.
When can it be helpful?
knitr
or testthat
in a console
rlang::is_interactive()
as FALSE
, where base
version is TRUE
The {verdepcheck}
GitHub workflow ran successfully
This PR should also fix the GRAN and r-universe build fails.
Pull Request
Changes description
eval=base::interactive()
to chunk options in vignettesHow to test
rmcdcheck::rmcdcheck()
scheduled.yaml
Github action and all strategies complete successfully