insightsengineering / teal.modules.general

General Purpose Teal Modules
https://insightsengineering.github.io/teal.modules.general/
Other
9 stars 13 forks source link

[Bug]: new 'ggpp' release 0.5.7 #748

Closed aphalo closed 4 months ago

aphalo commented 6 months ago

What happened?

Not really a bug, but I am about to submit 'ggpp' 0.5.7 to CRAN. Using 'revdepcheck' locally, the check of 'teal.modules.general' does not complete (has been now running for nearly 2 hours and continues). You may like to check that the new version of 'ggpp' does not break anything. I do not expect it to break anything. It does depend on 'ggplot2' >= 3.5.0 while your package depends on 'ggplot2' >= 3.4.0.

image

This is already a retry, so other reverse dependencies had already been checked good the day before.

sessionInfo()

No response

Relevant log output

No response

Code of Conduct

Contribution Guidelines

Security Policy

donyunardi commented 6 months ago

Thanks for the heads up @aphalo We'll double check again on our end.

averissimo commented 4 months ago

Some unique scenario may have happened with that revdepcheck. I've tried replicating it as well as doing the recommended replacement method of tools::check_packages_in_dir() and no errors nor stalls happened (as revdepcheck is unmaintained).

Tested with ggpp 0.5.7, 0.5.8 and 0.5.8-2

Thanks for reporting and create a new issue if the issue reappears

ps. internally we are doing weekly testing with main version of all dependencies and that is passing: see max strategy