insightsengineering / teal.modules.general

General Purpose Teal Modules
https://insightsengineering.github.io/teal.modules.general/
Other
9 stars 13 forks source link

553 change level in `log_shiny_input_changes` and exclude plot sizes in logging #760

Closed m7pr closed 5 months ago

m7pr commented 5 months ago

Part of https://github.com/insightsengineering/coredev-tasks/issues/553 and https://github.com/insightsengineering/coredev-tasks/issues/568

github-actions[bot] commented 5 months ago

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------
R/tm_a_pca.R                    827     827  0.00%    108-1068
R/tm_a_regression.R             773     773  0.00%    153-1031
R/tm_data_table.R               185     185  0.00%    93-332
R/tm_file_viewer.R              173     173  0.00%    44-252
R/tm_front_page.R               133     122  8.27%    70-228
R/tm_g_association.R            330     330  0.00%    135-537
R/tm_g_bivariate.R              672     410  38.99%   303-769, 810, 921, 938, 956, 967-989
R/tm_g_distribution.R          1050    1050  0.00%    122-1311
R/tm_g_response.R               351     351  0.00%    154-578
R/tm_g_scatterplot.R            722     722  0.00%    230-1053
R/tm_g_scatterplotmatrix.R      278     259  6.83%    165-472, 533, 547
R/tm_missing_data.R            1069    1069  0.00%    92-1317
R/tm_outliers.R                 985     985  0.00%    134-1263
R/tm_t_crosstable.R             251     251  0.00%    141-440
R/tm_variable_browser.R         830     825  0.60%    79-1071, 1109-1293
R/utils.R                        99      96  3.03%    82-267
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          8730    8430  3.44%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 421cfc3246397c9ad5bd683ba91a799741d958e0

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 5 months ago

Unit Tests Summary

  1 files   22 suites   13m 21s :stopwatch: 147 tests 147 :white_check_mark: 0 :zzz: 0 :x: 478 runs  478 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 421cfc32.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 5 months ago

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_pca 💚 $120.75$ $-6.37$ $0$ $0$ $0$ $0$
shinytest2-tm_a_regression 💚 $56.66$ $-4.75$ $0$ $0$ $0$ $0$
shinytest2-tm_data_table 💚 $21.16$ $-1.39$ $0$ $0$ $0$ $0$
shinytest2-tm_g_association 💚 $34.03$ $-4.29$ $0$ $0$ $0$ $0$
shinytest2-tm_g_bivariate 💚 $78.34$ $-3.28$ $0$ $0$ $0$ $0$
shinytest2-tm_g_distribution 💚 $65.95$ $-9.30$ $0$ $0$ $0$ $0$
shinytest2-tm_g_response 💚 $29.45$ $-2.84$ $0$ $0$ $0$ $0$
shinytest2-tm_g_scatterplot 💚 $83.16$ $-10.55$ $0$ $0$ $0$ $0$
shinytest2-tm_g_scatterplotmatrix 💚 $29.42$ $-1.26$ $0$ $0$ $0$ $0$
shinytest2-tm_misssing_data 💚 $52.72$ $-6.60$ $0$ $0$ $0$ $0$
shinytest2-tm_outliers 💚 $132.80$ $-31.37$ $0$ $0$ $0$ $0$
shinytest2-tm_t_crosstable 💚 $34.96$ $-3.47$ $0$ $0$ $0$ $0$
shinytest2-tm_variable_browser 💚 $77.80$ $-15.84$ $0$ $0$ $0$ $0$
Additional test case details | Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | shinytest2-tm_a_pca | 💚 | $8.56$ | $-1.00$ | e2e_tm_a_pca_Eigenvector_table_should_have_data_extract_selection_Murder_UrbanPop_on_header. | | shinytest2-tm_a_regression | 💚 | $12.42$ | $-1.13$ | e2e_tm_a_regression_Plot_type_has_7_specific_choices_changing_choices_does_not_throw_errors. | | shinytest2-tm_a_regression | 💚 | $12.60$ | $-2.20$ | e2e_tm_a_regression_Unchecking_display_outlier_hides_outlier_label_and_definition. | | shinytest2-tm_g_association | 💚 | $10.48$ | $-2.66$ | e2e_tm_g_association_Module_plot_is_visible. | | shinytest2-tm_g_bivariate | 💚 | $27.02$ | $-2.53$ | e2e_tm_g_bivariate_Setting_encoding_inputs_produces_outputs_without_validation_errors. | | shinytest2-tm_g_distribution | 💚 | $20.25$ | $-5.37$ | e2e_tm_g_distribution_Histogram_encoding_inputs_produce_output_without_validation_errors. | | shinytest2-tm_g_distribution | 💚 | $32.15$ | $-1.17$ | e2e_tm_g_distribution_Module_is_initialised_with_the_specified_defaults. | | shinytest2-tm_g_distribution | 💚 | $13.56$ | $-2.75$ | e2e_tm_g_distribution_QQ_plot_encoding_inputs_produce_output_without_validation_errors. | | shinytest2-tm_g_response | 💚 | $12.33$ | $-1.34$ | e2e_tm_g_response_encoding_inputs_produce_output_without_validation_errors. | | shinytest2-tm_g_scatterplot | 💚 | $10.48$ | $-2.12$ | e2e_tm_g_scatterplot_Base_for_the_log_transformation_can_be_applied. | | shinytest2-tm_g_scatterplot | 💚 | $8.60$ | $-1.49$ | e2e_tm_g_scatterplot_Get_validation_error_when_facetting_with_the_same_row_col_variable. | | shinytest2-tm_g_scatterplot | 💚 | $7.16$ | $-1.08$ | e2e_tm_g_scatterplot_Module_is_initialised_with_the_specified_defaults. | | shinytest2-tm_g_scatterplot | 💚 | $45.88$ | $-3.79$ | e2e_tm_g_scatterplot_The_encoding_inputs_produce_output_without_validation_errors. | | shinytest2-tm_g_scatterplot | 💚 | $11.03$ | $-2.07$ | e2e_tm_g_scatterplot_The_log_transform_is_only_possible_for_positive_numeric_vars. | | shinytest2-tm_misssing_data | 💚 | $15.14$ | $-2.94$ | e2e_tm_missing_data_Default_settings_and_visibility_of_the_summary_graph | | shinytest2-tm_misssing_data | 💚 | $6.92$ | $-1.35$ | e2e_tm_missing_data_Validate_By_Variable_Levels_table_values | | shinytest2-tm_misssing_data | 💚 | $11.68$ | $-1.63$ | e2e_tm_missing_data_Validate_functionality_and_UI_response_for_By_Variable_Levels_ | | shinytest2-tm_outliers | 💚 | $12.10$ | $-3.07$ | e2e_tm_outliers_Data_extract_spec_elements_are_initialized_with_the_default_values_specified_by_outlier_var_and_categorical_var_argument. | | shinytest2-tm_outliers | 💚 | $6.99$ | $-1.08$ | e2e_tm_outliers_Data_parameter_and_module_label_is_passed_properly. | | shinytest2-tm_outliers | 💚 | $11.88$ | $-3.16$ | e2e_tm_outliers_Default_radio_buttons_are_set_properly. | | shinytest2-tm_outliers | 💚 | $7.07$ | $-1.21$ | e2e_tm_outliers_Method_parameters_are_set_properly. | | shinytest2-tm_outliers | 💚 | $7.49$ | $-1.62$ | e2e_tm_outliers_Module_is_divided_into_3_tabs. | | shinytest2-tm_outliers | 💚 | $30.03$ | $-5.97$ | e2e_tm_outliers_Outlier_definition_text_and_range_are_displayed_properly_depending_on_method. | | shinytest2-tm_outliers | 💚 | $11.40$ | $-2.67$ | e2e_tm_outliers_Outlier_table_is_displayed_with_proper_content. | | shinytest2-tm_outliers | 💚 | $14.19$ | $-4.27$ | e2e_tm_outliers_Outliers_summary_table_is_displayed_with_proper_content. | | shinytest2-tm_outliers | 💚 | $9.56$ | $-2.22$ | e2e_tm_outliers_Plot_type_is_correctly_set_by_default_and_has_appropriate_possible_options. | | shinytest2-tm_outliers | 💚 | $22.11$ | $-6.10$ | e2e_tm_outliers_Plot_type_is_hidden_when_Boxplot_tab_is_not_selected. | | shinytest2-tm_t_crosstable | 💚 | $13.08$ | $-2.62$ | e2e_tm_t_crosstable_Change_plot_settings | | shinytest2-tm_variable_browser | 💚 | $11.39$ | $-3.23$ | e2e_tm_variable_browser_Selecting_treat_variable_as_factor_changes_the_table_headers. | | shinytest2-tm_variable_browser | 💚 | $13.24$ | $-2.74$ | e2e_tm_variable_browser_changing_display_density_encoding_doesn_t_show_errors. | | shinytest2-tm_variable_browser | 💚 | $15.37$ | $-1.42$ | e2e_tm_variable_browser_changing_outlier_definition_encoding_doesn_t_show_errors. | | shinytest2-tm_variable_browser | 💚 | $18.56$ | $-4.24$ | e2e_tm_variable_browser_changing_plot_setting_encodings_doesn_t_show_errors. | | shinytest2-tm_variable_browser | 💚 | $10.62$ | $-2.76$ | e2e_tm_variable_browser_content_is_displayed_correctly. | | shinytest2-tm_variable_browser | 💚 | $8.61$ | $-1.46$ | e2e_tm_variable_browser_selection_of_categorical_variable_has_a_table_with_level_header. |

Results for commit 5eca0f4e519e5d2ad0a3173c7c2d15534d1e82ff

♻️ This comment has been updated with latest results.