search

insightsengineering / teal.modules.general

General Purpose Teal Modules
https://insightsengineering.github.io/teal.modules.general/
Other
9 stars 13 forks source link

`teal.data::datanames()` is deprecated in favor of dot-prefix and `names()` #794

Closed averissimo closed 1 week ago

averissimo commented 2 weeks ago

Pull Request

Part of https://github.com/insightsengineering/teal.data/issues/333

Blocked by:

averissimo commented 2 weeks ago

I'm using the following bash command to make sure I can find ls( occurrences in the middle of so many false positives

export MY_REGEX="vitals|formals|levels|labels|cols"
grep -E "(${MY_REGEX}|ls)\(" -R | sed -E "s/(${MY_REGEX})\(/xxxx\(/g" | grep "ls("
github-actions[bot] commented 2 weeks ago

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------
R/tm_a_pca.R                    827     827  0.00%    106-1066
R/tm_a_regression.R             773     773  0.00%    150-1028
R/tm_data_table.R               185     185  0.00%    100-339
R/tm_file_viewer.R              173     173  0.00%    47-255
R/tm_front_page.R               133     122  8.27%    73-231
R/tm_g_association.R            330     330  0.00%    134-536
R/tm_g_bivariate.R              672     410  38.99%   301-767, 808, 919, 936, 954, 965-987
R/tm_g_distribution.R          1048    1048  0.00%    125-1311
R/tm_g_response.R               351     351  0.00%    151-575
R/tm_g_scatterplot.R            722     722  0.00%    233-1056
R/tm_g_scatterplotmatrix.R      278     259  6.83%    172-479, 540, 554
R/tm_missing_data.R            1070    1070  0.00%    91-1317
R/tm_outliers.R                 985     985  0.00%    129-1258
R/tm_t_crosstable.R             251     251  0.00%    138-437
R/tm_variable_browser.R         830     825  0.60%    89-1081, 1119-1303
R/utils.R                        99      96  3.03%    82-267
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          8729    8429  3.44%

Diff against main

Filename               Stmts    Miss  Cover
-------------------  -------  ------  --------
R/tm_missing_data.R       +1      +1  +100.00%
TOTAL                     +1      +1  -0.00%

Results for commit: 2b26a4527fe302b059816efbfacd88942e1508be

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 2 weeks ago

Unit Tests Summary

  1 files   22 suites   12m 58s ⏱️ 147 tests 147 ✅ 0 💤 0 ❌ 479 runs  479 ✅ 0 💤 0 ❌

Results for commit 2b26a452.

:recycle: This comment has been updated with latest results.