forestplot subgroup variable selection should be more user friendly

insightsengineering / teal.modules.hermes

RNA-seq analysis modules to add to a teal application

https://insightsengineering.github.io/teal.modules.hermes/

Other

7 stars 1 forks source link

forestplot subgroup variable selection should be more user friendly #198

Closed danielinteractive closed 2 years ago

danielinteractive commented 2 years ago

Problem:

All subgroup variables are shown in the drop-down menu.

To do:

[x] Rename drop-down to Select Categorical Subgroup Variable
[x] Show only character / factor variables in the drop-down
[x] Test what happens if there are no character / factor variables

AniaGolab commented 2 years ago

Hi Daniel, The linked request adds "Categorical" to description. I can also confirm that the variables outputted in the drop-down are only categorical (via categorical=TRUE set-up). I also checked what happens if no categorical variables are present in the mae via SummarizedExperiment::colData(mae)["AGE"] . In such case the application runs correctly and simply outputs no variables to group by (empty list). Fixes #198