insightsengineering / teal.modules.hermes

RNA-seq analysis modules to add to a teal application
https://insightsengineering.github.io/teal.modules.hermes/
Other
7 stars 1 forks source link

323 [Bug]: Uncaught error in Barplot module #326

Closed BFalquet closed 1 year ago

BFalquet commented 1 year ago

close #323

Add missing reactivity element that prevents correct update when data is filtered.

thank you for the review

github-actions[bot] commented 1 year ago

badge

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/adtteSpec.R           156     113  27.56%   248-383
R/assaySpec.R            44      36  18.18%   103-142
R/barplot.R             169     136  19.53%   40-64, 123-259
R/boxplot.R             172     144  16.28%   41-65, 119-260
R/checkmate.R            18       9  50.00%   110-118
R/experimentSpec.R       89      56  37.08%   97, 215-282
R/forestplot.R          197     172  12.69%   60-91, 147-312
R/geneSpec.R            255     153  40.00%   153-168, 297-481
R/km.R                  189     158  16.40%   63-92, 153-307
R/pca.R                 355     272  23.38%   35-55, 163-464
R/quality.R             298     228  23.49%   18-109, 203-431
R/sampleVarSpec.R       236     104  55.93%   295, 314-323, 329-336, 338, 346-358, 360-361, 363, 366, 374-378, 380-395, 400-424, 427-431, 433, 440-450, 452-453, 461, 506-523
R/scatterplot.R         167     137  17.96%   40-64, 122-258
R/utils.R                16       5  68.75%   74-78
R/volcanoplot.R         193     163  15.54%   35-56, 111-280
R/zzz.R                   1       1  0.00%    2
TOTAL                  2555    1887  26.14%

Diff against main

Filename             Stmts    Miss  Cover
-----------------  -------  ------  -------
R/sampleVarSpec.R       +4      +1  +0.33%
TOTAL                   +4      +1  +0.08%

Results for commit: ebcf2d12940fbc02196ef864bf901f493127dec5

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 1 year ago

Unit Tests Summary

  1 files  15 suites   10s :stopwatch: 56 tests 43 :heavy_check_mark: 13 :zzz: 0 :x: 85 runs  72 :heavy_check_mark: 13 :zzz: 0 :x:

Results for commit b446ff82.