search

insightsengineering / teal.modules.hermes

RNA-seq analysis modules to add to a teal application
https://insightsengineering.github.io/teal.modules.hermes/
Other
7 stars 1 forks source link

198 Include user's card labels when generating the report #336

Closed kartikeyakirar closed 1 year ago

kartikeyakirar commented 1 year ago

this PR fixes https://github.com/insightsengineering/teal.modules.hermes/issues/335

this is follow-up after https://github.com/insightsengineering/teal.reporter/pull/219

github-actions[bot] commented 1 year ago

badge

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/adtteSpec.R           168     121  27.98%   252-397
R/assaySpec.R            53      39  26.42%   109-151
R/barplot.R             171     138  19.30%   40-64, 123-261
R/boxplot.R             174     146  16.09%   41-65, 119-262
R/checkmate.R            18       9  50.00%   110-118
R/experimentSpec.R       89      56  37.08%   97, 215-282
R/forestplot.R          199     174  12.56%   60-91, 147-314
R/geneSpec.R            256     153  40.23%   154-169, 298-482
R/km.R                  191     160  16.23%   63-92, 153-309
R/pca.R                 357     274  23.25%   35-55, 163-466
R/quality.R             300     230  23.33%   18-109, 203-433
R/sampleVarSpec.R       236     104  55.93%   295, 314-323, 329-336, 338, 346-358, 360-361, 363, 366, 374-378, 380-395, 400-424, 427-431, 433, 440-450, 452-453, 461, 506-523
R/scatterplot.R         169     139  17.75%   40-64, 122-260
R/utils.R                16       0  100.00%
R/volcanoplot.R         195     165  15.38%   35-56, 111-282
R/zzz.R                   1       1  0.00%    2
TOTAL                  2593    1909  26.38%

Diff against main

Filename           Stmts    Miss  Cover
---------------  -------  ------  -------
R/barplot.R           +2      +2  -0.23%
R/boxplot.R           +2      +2  -0.19%
R/forestplot.R        +2      +2  -0.13%
R/km.R                +2      +2  -0.17%
R/pca.R               +2      +2  -0.13%
R/quality.R           +2      +2  -0.16%
R/scatterplot.R       +2      +2  -0.21%
R/volcanoplot.R       +2      +2  -0.16%
TOTAL                +16     +16  -0.16%

Results for commit: 068f65a41106dae6dbdd43638ad0a25cbd27c31e

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 1 year ago

Unit Tests Summary

  1 files  15 suites   9s :stopwatch: 56 tests 43 :heavy_check_mark: 13 :zzz: 0 :x: 94 runs  81 :heavy_check_mark: 13 :zzz: 0 :x:

Results for commit 068f65a4.

:recycle: This comment has been updated with latest results.

kartikeyakirar commented 1 year ago

is there something that should go into the shiny tests accordingly?

@danielinteractive I haven't made any specific changes for shinytest, but I've included a test for card_template().

m7pr commented 1 year ago

@kartikeyakirar please take out card_template and move it to teal.reporter. Move the test as well https://github.com/insightsengineering/teal.modules.general/pull/584#issuecomment-1750699411