search

insightsengineering / teal.modules.hermes

RNA-seq analysis modules to add to a teal application
https://insightsengineering.github.io/teal.modules.hermes/
Other
7 stars 1 forks source link

remove function call from package using `::` for fully imported packages #337

Open kartikeyakirar opened 1 year ago

kartikeyakirar commented 1 year ago

Feature description

Based on the conversation https://github.com/insightsengineering/teal.modules.hermes/pull/336#discussion_r1348152030, it has been observed that there is a package-wide usage of the :: namespace call for function from the fully imported packages.

Acceptance Criteria: To meet the acceptance criteria, we need to remove these namespace references (from packages that are fully imported) and ensure that everything functions as expected.

kartikeyakirar commented 1 year ago

Additional Comments: In most other teal modules, the convention is to include the package name before package functions. This practice enhances the debugging experience when working with functions. Perhaps this convention could also be applied here to maintain consistency across all nest packages.

danielinteractive commented 1 year ago

The point is that when the whole of another package is imported (that is, copied into our namespace) then it does not make sense to still access the functions in the other namespace.