insightsengineering / teal.modules.hermes

RNA-seq analysis modules to add to a teal application
https://insightsengineering.github.io/teal.modules.hermes/
Other
7 stars 1 forks source link

Fix modules to use `teal_data` instead of `tdata` #338

Closed gogonzo closed 11 months ago

gogonzo commented 1 year ago

part of https://github.com/insightsengineering/teal/issues/937

installation instructions:

staged.dependencies::dependency_table(
  project = "insightsengineering/teal.modules.hermes@https://github.com",
  project_type = "repo@host",
  ref = "refactor",
  verbose = 1
) |>
staged.dependencies::install_deps()

Why only a single branch/PR for this?

The tdata changes are well modularised into experimentSpec.R and adtteSpec.R which process the tdata and provide functions that can be used in the modules to get the MAE data, and the modules are using this MAE data throughout and do not care about tdata or teal_data.

Review Steps:

  1. Assign yourself by writing your name next to the module in "Review list" below.
  2. Review the corresponding module
  3. Make any suggestions on the PR ;)

Review list:

gogonzo commented 11 months ago

Closing an issue as changes are already on the feature branch