Closed chlebowa closed 11 months ago
Hey @chlebowa since the teal_data
passed to the UI is being depreciated, what are your thoughts on using reactive(<teal_data>)
throughout the places regardless if it's a module UI or module Server?
I kinda liked the convention that the UI functions use a non-reactive teal_data
and will not try to rerender when the teal_data changes. Because of this change, we have to pass the reactive data https://github.com/insightsengineering/teal.modules.hermes/pull/348/commits/d4c1b9882a10555ae923a0d0bcdde23ba0f46db6 and I think this is not right because the filter state change should not affect the encoding panel UI and passing a non-reactive data communicates this. Whatever we decide, we will have to do the same in the teal.modules.helios's experimentSpecInput too.
Hey @chlebowa since the
teal_data
passed to the UI is being depreciated, what are your thoughts on usingreactive(<teal_data>)
throughout the places regardless if it's a module UI or module Server?
I don't understand the question. We are moving away from using data in modules' ui functions.
Encodings depending on data (and therefore invalidating when filter state changes) would be an issue, yes. There are plans to deal with it.
Fixes this issue
Modified example for
adtteSpec
to also includeADSL
dataset. :exclamation: I had to take it fromteal.data
so it's probably not the ideal solution. AdaptedexperimentSpec
to newteal_data
class.