search

insightsengineering / teal.modules.hermes

RNA-seq analysis modules to add to a teal application
https://insightsengineering.github.io/teal.modules.hermes/
Other
7 stars 1 forks source link

503 shinytest2 : migrate test to shinytest2 using TealAppDriver #375

Open kartikeyakirar opened 7 months ago

kartikeyakirar commented 7 months ago

part of https://github.com/insightsengineering/coredev-tasks/issues/503

github-actions[bot] commented 7 months ago

badge

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/adtteSpec.R           170     123  27.65%   253-400
R/assaySpec.R            53      39  26.42%   104-146
R/barplot.R             187     151  19.25%   39-66, 129-279
R/boxplot.R             189     158  16.40%   40-67, 125-278
R/checkmate.R            18       9  50.00%   110-118
R/experimentSpec.R       90      57  36.67%   97, 215-283
R/forestplot.R          213     185  13.15%   58-92, 152-326
R/geneSpec.R            256     153  40.23%   154-169, 296-480
R/km.R                  207     173  16.43%   61-92, 156-325
R/pca.R                 366     283  22.68%   34-56, 165-476
R/quality.R             319     246  22.88%   18-110, 208-453
R/sampleVarSpec.R       236     104  55.93%   299, 318-327, 333-340, 342, 350-362, 364-365, 367, 370, 378-382, 384-399, 404-428, 431-435, 437, 444-454, 456-457, 465, 510-527
R/scatterplot.R         180     147  18.33%   39-65, 127-272
R/utils.R                16       0  100.00%
R/volcanoplot.R         203     173  14.78%   34-57, 113-292
R/zzz.R                   2       2  0.00%    2-3
TOTAL                  2705    2003  25.95%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: fb6f8e3baf266d293b7115afb8dd7982c5eda652

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 7 months ago

Unit Tests Summary

  1 files   16 suites   11s :stopwatch:  56 tests  43 :white_check_mark: 13 :zzz: 0 :x: 538 runs  525 :white_check_mark: 13 :zzz: 0 :x:

Results for commit fb6f8e3b.

github-actions[bot] commented 7 months ago

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-adtteSpec 👶 $+0.01$ $+1$ $+1$ $0$ $0$
Additional test case details | Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | adtteSpec | 💀 | $0.03$ | $-0.03$ | adtteSpecServer_module_works_as_expected_in_the_test_app | | shinytest2-adtteSpec | 👶 | | $+0.01$ | adtteSpecServer_module_works_as_expected_in_the_test_app |

Results for commit 0a542d1c163f734e4c5815473a726f9a3b438d67

♻️ This comment has been updated with latest results.

danielinteractive commented 5 months ago

Hi @kartikeyakirar , what is the state of this PR?

kartikeyakirar commented 5 months ago

Hey @danielinteractive, cc @donyunardi

Just wanted to update you on a couple of PRs:

https://github.com/insightsengineering/teal.modules.helios/pull/130 https://github.com/insightsengineering/teal.modules.hermes/pull/375 Both were aimed at modifying shiny test2 using tealAppDriver. However, they're currently on hold due to discussions regarding the addition of a method for selecting MAE dataset in https://github.com/insightsengineering/teal/pull/1190. It was decided later that this wouldn't be part of tealAppDriver and will instead be tested in teal.slice itself.

we're prioritized the addition of shinytest2 in tmc and tmg. I'll be picking these PRs back up shortly, but until then, they're on hold.