insightsengineering / teal.reporter

Create and preview reports with Shiny modules
https://insightsengineering.github.io/teal.reporter/
Other
8 stars 9 forks source link

1290 reporter previewer buttons overlap #282

Closed m7pr closed 3 months ago

m7pr commented 3 months ago

Fixes https://github.com/insightsengineering/teal/issues/1290 as a part of https://github.com/insightsengineering/teal/pull/1253

Status: currently managed to figure out application on divs on buttons so they do not overlap Now: planning to put each button in a separate line so they do not go out of the encodings panel

library(shiny)
library(teal.reporter)

shinyApp(
  ui = fluidPage(reporter_previewer_ui("simple")),
  server = function(input, output, session) {
    reporter_previewer_srv("simple", Reporter$new())
  }
)
image
github-actions[bot] commented 3 months ago

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

m7pr commented 3 months ago

I have read the CLA Document and I hereby sign the CLA

vedhav commented 3 months ago

I have read the CLA Document and I hereby sign the CLA

github-actions[bot] commented 3 months ago

badge

Code Coverage Summary

Filename                  Stmts    Miss  Cover    Missing
----------------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------
R/AddCardModule.R           146       2  98.63%   170, 207
R/ContentBlock.R             18       2  88.89%   57-63
R/DownloadModule.R          238      67  71.85%   98-104, 152, 183-188, 197-202, 205-210, 219-224, 227-232, 240-245, 248-253, 260-265, 268-273, 312-316
R/FileBlock.R                13       0  100.00%
R/LoadReporterModule.R      103      19  81.55%   100-105, 108-113, 119-124, 136
R/NewpageBlock.R              2       0  100.00%
R/PictureBlock.R             30       2  93.33%   20, 118
R/Previewer.R               372      95  74.46%   96-98, 101-102, 184-213, 217-219, 222, 289, 304, 306-309, 312, 315-323, 437-481
R/RcodeBlock.R               15       0  100.00%
R/Renderer.R                113      37  67.26%   97-112, 216, 224, 233, 235-256
R/ReportCard.R               84       3  96.43%   239, 244, 269
R/Reporter.R                107       6  94.39%   273-278
R/ResetModule.R              53       0  100.00%
R/SimpleReporter.R           32       0  100.00%
R/TableBlock.R                9       0  100.00%
R/TextBlock.R                13       0  100.00%
R/utils.R                   126      86  31.75%   7, 38-97, 99, 102-109, 137, 161-169, 206-215
R/yaml_utils.R               81       2  97.53%   78, 289
R/zzz.R                      14      10  28.57%   2-13, 19
TOTAL                      1569     331  78.90%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 05128070dda5bd94e01d204b4c5b219e451d600c

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 3 months ago

Unit Tests Summary

  1 files   18 suites   33s :stopwatch: 189 tests 189 :white_check_mark: 0 :zzz: 0 :x: 329 runs  329 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 05128070.

:recycle: This comment has been updated with latest results.

m7pr commented 3 months ago

Current state after @vedhav improvements

image image
vedhav commented 3 months ago

Just linted the css file as it was crazy before :)

vedhav commented 3 months ago

We can wait before the merge. We could have other changes and it looks like the stable version does not have this bug and only the dev version does. image image