insightsengineering / teal.slice

Reproducible slice module for teal applications
https://insightsengineering.github.io/teal.slice/
Other
11 stars 5 forks source link

filter manager dialog doesn't handle too many modules #394

Open chlebowa opened 1 year ago

chlebowa commented 1 year ago

image

chlebowa commented 1 year ago

Updating CSS with scroll: overflow helps but the aesthetics needs work.

image

donyunardi commented 1 year ago

Acceptance Criteria

averissimo commented 1 year ago

To consider:

Using overflow-x: scroll and adding row-gap: 2em on the parent element with class filter_manager_content)

The row-gap only appears if flex overflows to 2 rows (so there's no additional padding in most scenarios)

image

averissimo commented 1 year ago

There's an edge case when:

To avoid that we may hide filters when they are more than X (X = 5 in the mock below, but should be more)

The caveat is that this only makes sense in single "column mode", as in most dashboards both columns are visible.

image