insightsengineering / teal.slice

Reproducible slice module for teal applications
https://insightsengineering.github.io/teal.slice/
Other
11 stars 5 forks source link

548 remove private/internal examples #550

Closed m7pr closed 5 months ago

m7pr commented 5 months ago

Closes #548

github-actions[bot] commented 5 months ago

Unit Tests Summary

  1 files   29 suites   22s :stopwatch: 359 tests 359 :white_check_mark: 0 :zzz: 0 :x: 822 runs  822 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 25fb8992.

github-actions[bot] commented 5 months ago

badge

Code Coverage Summary

Filename                        Stmts    Miss  Cover    Missing
----------------------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------------------------------------------------------
R/calls_combine_by.R                7       0  100.00%
R/choices_labeled.R                49      14  71.43%   25, 36, 41, 51-56, 68, 72-76
R/count_labels.R                   97       0  100.00%
R/filter_panel_api.R               29       1  96.55%   129
R/FilteredData-utils.R             68      25  63.24%   21-24, 27-30, 52-57, 101, 123-132
R/FilteredData.R                  554     219  60.47%   57, 131, 273, 345, 448-457, 480, 501-542, 560-563, 579, 620-653, 668-670, 674-680, 709-737, 760-762, 766-768, 771-782, 786-795, 797-835, 876, 899-921
R/FilteredDataset-utils.R          23       1  95.65%   122
R/FilteredDataset.R               170      61  64.12%   52, 152, 191, 216-273, 312-314
R/FilteredDatasetDataframe.R      121       8  93.39%   62, 123, 133, 209-213
R/FilteredDatasetDefault.R         18       4  77.78%   93-106
R/FilteredDatasetMAE.R            134      37  72.39%   31, 92-97, 136-141, 145-146, 164-186
R/FilterPanelAPI.R                 10       0  100.00%
R/FilterState-utils.R             101       2  98.02%   222, 252
R/FilterState.R                   361      61  83.10%   89, 212, 230-234, 241-242, 256-257, 263-264, 311, 313, 315, 367, 411, 639, 682-705, 715-734, 769-775, 784-790
R/FilterStateChoices.R            341     108  68.33%   207-210, 222, 264, 286-293, 297-314, 342, 355-366, 378-386, 390-419, 440-443, 446-449, 460-483, 494, 499, 510
R/FilterStateDate.R               212     129  39.15%   130, 182-339
R/FilterStateDatettime.R          309     199  35.60%   163, 215-446
R/FilterStateEmpty.R               53      31  41.51%   73, 83-88, 101, 113-153
R/FilterStateExpr.R                75      62  17.33%   100-223
R/FilterStateLogical.R            196     144  26.53%   53, 75, 135, 139-323
R/FilterStateRange.R              408     105  74.26%   151, 273, 399-403, 406-416, 419, 431-437, 448-460, 464-474, 478-480, 494-521, 536, 539, 553-570, 605-610, 620-622
R/FilterStates-utils.R             70       9  87.14%   72, 91, 141-147, 169, 198
R/FilterStates.R                  364      30  91.76%   78-82, 191, 314-323, 411-414, 457, 542-546, 591, 712-715
R/FilterStatesDF.R                  5       0  100.00%
R/FilterStatesMAE.R                10       1  90.00%   40
R/FilterStatesMatrix.R              3       0  100.00%
R/FilterStatesSE.R                211     157  25.59%   36, 71-73, 83-85, 109-116, 124-131, 154-302
R/include_css_js.R                  5       5  0.00%    12-16
R/teal_slice.R                    107       4  96.26%   134, 188-189, 200
R/teal_slices.R                    84       5  94.05%   144-149
R/test_utils.R                     21       0  100.00%
R/utils.R                          18       0  100.00%
R/variable_types.R                 15       8  46.67%   17-24
R/zzz.R                            16      16  0.00%    3-46
TOTAL                            4265    1446  66.10%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 25fb8992cc3d2a4fccbf9e1079f205573c052233

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

m7pr commented 5 months ago

Yes to both! I think we did send examples in this manner with teal.code so I don't understand why this is an issue again. Probably depending on the reviewer. I would try sending with those examples at the first attempt.

chlebowa commented 5 months ago

we did send examples in this manner with teal.code

But that was on _re_submission.

averissimo commented 5 months ago

We want to submit this in a process that doesn't land on a human (and hope it's not an issue down the line).

This information is (approximately) summarised in the following diagram by Hadley Wickham, available in the cran-stages Github repository:

image

m7pr commented 5 months ago

Merging to release-candidate branch, as we agreed during the discussion