insightsengineering / teal

Exploratory Web Apps for Analyzing Clinical Trial Data
https://insightsengineering.github.io/teal/
Other
171 stars 34 forks source link

1125 bug fix@main #1126

Closed chlebowa closed 6 months ago

chlebowa commented 6 months ago

Fixes #1125

Fixed resolving the datanames property of teal_module in modules_datasets. Also, removed function resolve_modules_datanames because it was no longer used.

github-actions[bot] commented 6 months ago

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/dummy_functions.R                  30      21  30.00%   21-33, 36-43
R/get_rcode_utils.R                  31       1  96.77%   50
R/include_css_js.R                   22       0  100.00%
R/init.R                             86      31  63.95%   107-114, 160-161, 163, 175-196, 226-227, 229
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_filter_manager.R           107      36  66.36%   37-43, 50-58, 67-72, 195, 200-213
R/module_nested_tabs.R              154      58  62.34%   39-112, 128, 180, 202, 228
R/module_snapshot_manager.R         209     157  24.88%   87-99, 127-136, 140-152, 154-161, 168-182, 186-188, 190-195, 198-208, 211-227, 236-251, 265-288, 291-302, 305-311, 325, 343-366
R/module_tabs_with_filters.R         76      33  56.58%   33-68, 100, 116
R/module_teal_with_splash.R         114       4  96.49%   110, 131, 197-198
R/module_teal.R                     106      29  72.64%   57, 68, 77, 150-151, 157, 176-207
R/modules.R                         153      27  82.35%   127-130, 147-151, 206-210, 292-293, 345, 357-365, 419-422
R/reporter_previewer_module.R        18       2  88.89%   30, 34
R/show_rcode_modal.R                 19      19  0.00%    17-36
R/tdata.R                            53       1  98.11%   154
R/teal_data_module-eval_code.R       27       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                  6       0  100.00%
R/teal_reporter.R                    62       5  91.94%   69, 118-119, 122, 139
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      59      12  79.66%   137-150
R/utils.R                           172       1  99.42%   255
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   110-377
R/zzz.R                              11       7  36.36%   3-14
TOTAL                              1666     506  69.63%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  -------
R/utils.R       -24     -27  +13.70%
TOTAL           -24     -27  +1.17%

Results for commit: 1b57019c1d8f3d0dedc839dfc1981055461ecc68

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 6 months ago

Unit Tests Summary

  1 files   19 suites   10s :stopwatch: 208 tests 208 :white_check_mark: 0 :zzz: 0 :x: 419 runs  419 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 1b57019c.

pawelru commented 6 months ago

@chlebowa would you mind adding a NEWS entry (in a separate PR as this already got merged). This is relevant for potential patch release including this change. It would be good to have at least one entry in this file when releasing :)