insightsengineering / teal

Exploratory Web Apps for Analyzing Clinical Trial Data
https://insightsengineering.github.io/teal/
Other
171 stars 34 forks source link

use "|>" for teal families, as teal's R dependency is already at 4.0 #1143

Open shajoezhu opened 5 months ago

shajoezhu commented 5 months ago
          ok, i think we can do "|>" for teal families, as teal's R dependency is already at 4.0

but we can leave the static output ones a bit behind, (including tern)

eventually, when making cards an upstream dependencies of tern, we will switch |> for tern, the rest can stay %>% for a bit longer

Originally posted by @shajoezhu in https://github.com/insightsengineering/rtables/issues/838#issuecomment-1983554000

m7pr commented 5 months ago

|> was introduced in 4.1.0, not 4.0.0

https://cran.r-project.org/bin/windows/base/old/4.1.0/NEWS.R-4.1.0.html

R now provides a simple native forward pipe syntax |>. The simple form of the forward pipe inserts the left-hand side as the first argument in the right-hand side call. The pipe implementation as a syntax transformation was motivated by suggestions from Jim Hester and Lionel Henry.

m7pr commented 5 months ago

And teal just depends on 4.0.0 https://github.com/insightsengineering/teal/blob/beeb8da362e8c471b1ae30e4559244769defc947/DESCRIPTION#L38

averissimo commented 5 months ago

4.1 is 3 years old, maybe it's time we bump it :-)

m7pr commented 5 months ago

oh my