Closed m7pr closed 5 months ago
1 files 26 suites 1m 30s :stopwatch: 226 tests 226 :white_check_mark: 0 :zzz: 0 :x: 483 runs 483 :white_check_mark: 0 :zzz: 0 :x:
Results for commit a9c118f7.
:recycle: This comment has been updated with latest results.
Test Suite | $Status$ | Time on main |
$±Time$ | $±Tests$ | $±Skipped$ | $±Failures$ | $±Errors$ |
---|---|---|---|---|---|---|---|
shinytest2-show-rcode | 👶 | $+3.84$ | $+9$ | $0$ | $0$ | $0$ |
Results for commit dfafb4d3aabc0e478d696dff6c9991c0d7e75700
♻️ This comment has been updated with latest results.
testthat::expect_equal(
app$get_text("#shiny-modal > div > div > div.modal-header > h4"),
"Example Code"
)
is failing but I don't have that issue when running the test locally ...
testthat::expect_equal( app$get_text("#shiny-modal > div > div > div.modal-header > h4"), "Example Code" )
is failing but I don't have that issue when running the test locally ...
It's failing for me. Let me try to debug.
It's failing when I run the test but when I run the code inside the test, line by line it does not break.
Perhaps we need to wait after the click app$click(selector = button_selector)
Interactively there is a delay so it passes.
Yeah, adding app$wait_for_idle(timeout = default_idle_timeout)
after the click solves it!
aaaah, thanks! will push
Filename Stmts Miss Cover Missing
------------------------------ ------- ------ ------- -------------------------------------------------------------------------------------------------------------------------------
R/dummy_functions.R 30 0 100.00%
R/get_rcode_utils.R 31 1 96.77% 50
R/include_css_js.R 22 0 100.00%
R/init.R 86 25 70.93% 108-115, 161-162, 164, 179-185, 192-197, 228
R/landing_popup_module.R 25 25 0.00% 61-87
R/module_filter_manager.R 107 29 72.90% 50-58, 67-72, 195, 200-213
R/module_nested_tabs.R 154 3 98.05% 47, 128, 228
R/module_snapshot_manager.R 209 157 24.88% 87-99, 127-136, 140-152, 154-161, 168-182, 186-188, 190-195, 198-208, 211-227, 236-251, 265-288, 291-302, 305-311, 325, 343-366
R/module_tabs_with_filters.R 76 0 100.00%
R/module_teal_with_splash.R 114 2 98.25% 110, 131
R/module_teal.R 106 1 99.06% 57
R/modules.R 153 24 84.31% 127-130, 147-151, 206-210, 292-293, 345, 357-365
R/reporter_previewer_module.R 18 0 100.00%
R/show_rcode_modal.R 19 19 0.00% 17-36
R/tdata.R 53 1 98.11% 154
R/teal_data_module-eval_code.R 27 0 100.00%
R/teal_data_module-within.R 7 0 100.00%
R/teal_data_module.R 6 0 100.00%
R/teal_reporter.R 62 5 91.94% 69, 118-119, 122, 139
R/teal_slices-store.R 29 0 100.00%
R/teal_slices.R 59 12 79.66% 137-150
R/TealAppDriver.R 195 59 69.74% 66-77, 124-127, 135, 155, 167-168, 190-196, 278-325, 369, 402
R/utils.R 173 1 99.42% 255
R/validate_inputs.R 32 0 100.00%
R/validations.R 58 37 36.21% 110-377
R/zzz.R 11 7 36.36% 3-14
TOTAL 1862 408 78.09%
Filename Stmts Miss Cover
----------------- ------- ------ -------
R/TealAppDriver.R 0 -2 +1.03%
TOTAL 0 -2 +0.11%
Results for commit: a9c118f79e3d90d2bf1dba73a0fae1d8a890b90d
Minimum allowed coverage is 80%
:recycle: This comment has been updated with latest results
Hey @averissimo thanks for the review! I tried to apply comments from this PR, and the other one about Session Info.
About this
How about placing this on a different test file? It's only 2 tests but it might help to organize tests
This actually checks verbatim_popup
that is used by example_module
. This does not test R/show_rcode_modal
which is not used anymore. I could suggest we name the new file as tests/test-shinytest2-show-rcode.R
but I hope it's not gonna be confusing with R/show_rcode_modal
that I think we could completely remove https://github.com/insightsengineering/teal/issues/1154
moved the test to a separate file
Hey @averissimo I applied changes on this PR and used methods ($active_module_element
) that we created in other PRs.
I think this simple PR is ready to be merged.
Part of https://github.com/insightsengineering/coredev-tasks/issues/503