503 shinytest2 removes `helper_NS` method

[averissimo]

Pull Request

Part of https://github.com/insightsengineering/coredev-tasks/issues/503

Changes description

• Removes helper_NS function
• Removes outdated skip_if_not_installed("withr") calls

[github-actions[bot]]

Unit Tests Summary

  1 files  ±0   26 suites  ±0   1m 33s :stopwatch: +4s 225 tests ±0  225 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  462 runs  ±0  462 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit dfcd7ded. ± Comparison against base commit 4329d3cb.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
shinytest2-filter_panel	👶		$+5.54$	$+1$	$0$	$0$	$0$
shinytest2-init	👶		$+6.70$	$+5$	$0$	$0$	$0$
shinytest2-modules	👶		$+16.89$	$+6$	$0$	$0$	$0$
shinytest2-reporter	👶		$+5.93$	$+2$	$0$	$0$	$0$
shinytest2-snapshot	👶		$+31.46$	$+6$	$0$	$0$	$0$
shinytest2-teal_slices	👶		$+12.78$	$+19$	$0$	$0$	$0$
shinytest2-utils	👶		$+3.31$	$+4$	$0$	$0$	$0$

Additional test case details

| Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | shinytest2-filter_panel | 👶 | | $+5.54$ | e2e_module_content_is_updated_when_a_data_is_filtered_in_filter_panel | | shinytest2-init | 👶 | | $+3.39$ | e2e_init_creates_UI_containing_specified_title_favicon_header_and_footer | | shinytest2-init | 👶 | | $+3.32$ | e2e_teal_app_initializes_with_no_errors | | shinytest2-modules | 👶 | | $+3.01$ | e2e_all_the_nested_teal_modules_are_initiated_as_expected | | shinytest2-modules | 👶 | | $+3.12$ | e2e_filter_panel_is_not_displayed_when_datanames_is_NULL | | shinytest2-modules | 👶 | | $+3.36$ | e2e_filter_panel_only_shows_the_data_supplied_using_datanames | | shinytest2-modules | 👶 | | $+3.32$ | e2e_filter_panel_shows_all_the_datasets_when_datanames_is_all | | shinytest2-modules | 👶 | | $+4.08$ | e2e_the_module_server_logic_is_only_triggered_when_the_teal_module_becomes_active | | shinytest2-reporter | 👶 | | $+5.93$ | e2e_reporter_tab_is_only_created_when_a_module_has_reporter | | shinytest2-snapshot | 👶 | | $+6.25$ | e2e_Create_empty_snapshot | | shinytest2-snapshot | 👶 | | $+6.47$ | e2e_Download_filter_snapshot_with_non_empty_filters | | shinytest2-snapshot | 👶 | | $+6.13$ | e2e_Downloads_empty_snapshot | | shinytest2-snapshot | 👶 | | $+5.40$ | e2e_Snapshot_manager_can_reset_the_state | | shinytest2-snapshot | 👶 | | $+7.21$ | e2e_Upload_filter_snapshot_with_non_empty_filters | | shinytest2-teal_slices | 👶 | | $+4.83$ | e2e_teal_slices_filters_are_initialized_when_global_filters_are_created | | shinytest2-teal_slices | 👶 | | $+7.96$ | e2e_teal_slices_filters_are_initialized_when_module_specific_filters_are_created | | shinytest2-utils | 👶 | | $+3.31$ | e2e_show_hide_hamburger_works_as_expected |

Results for commit bef13e2b1204e340f6a352e609df91fa2e95c499

♻️ This comment has been updated with latest results.

[github-actions[bot]]

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  --------------------------------------------------------------
R/dummy_functions.R                  30       0  100.00%
R/get_rcode_utils.R                  31       1  96.77%   50
R/include_css_js.R                   22       0  100.00%
R/init.R                             86      25  70.93%   108-115, 161-162, 164, 179-185, 192-197, 228
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_filter_manager.R           107       1  99.07%   207
R/module_nested_tabs.R              154       3  98.05%   47, 128, 228
R/module_snapshot_manager.R         209      37  82.30%   142-146, 148-152, 191-195, 200-203, 205-208, 273-286
R/module_tabs_with_filters.R         76       0  100.00%
R/module_teal_with_splash.R         114       2  98.25%   110, 131
R/module_teal.R                     106       1  99.06%   57
R/modules.R                         153      24  84.31%   127-130, 147-151, 206-210, 292-293, 345, 357-365
R/reporter_previewer_module.R        18       1  94.44%   30
R/show_rcode_modal.R                 19      19  0.00%    17-36
R/tdata.R                            53       1  98.11%   154
R/teal_data_module-eval_code.R       27       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                  6       0  100.00%
R/teal_reporter.R                    62       5  91.94%   69, 118-119, 122, 139
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      59       0  100.00%
R/TealAppDriver.R                   196      44  77.55%   67-78, 123-126, 134, 144, 154, 175, 196-200, 308-331, 398, 415
R/utils.R                           173       1  99.42%   255
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   110-377
R/zzz.R                              11       7  36.36%   3-14
TOTAL                              1863     234  87.44%

Diff against main

Filename                         Stmts    Miss  Cover
-----------------------------  -------  ------  -------
R/dummy_functions.R                  0     -21  +70.00%
R/init.R                             0      -6  +6.98%
R/module_filter_manager.R            0     -35  +32.71%
R/module_nested_tabs.R               0     -55  +35.71%
R/module_snapshot_manager.R          0    -120  +57.42%
R/module_tabs_with_filters.R         0     -33  +43.42%
R/module_teal_with_splash.R          0      -2  +1.75%
R/module_teal.R                      0     -28  +26.42%
R/modules.R                          0      -3  +1.96%
R/reporter_previewer_module.R        0      -1  +5.56%
R/teal_slices.R                      0     -12  +20.34%
R/TealAppDriver.R                 +196     +44  +77.55%
R/utils.R                           +1       0  +0.00%
TOTAL                             +197    -272  +17.81%

Results for commit: dfcd7dedc783163c9e0c2d8b72ba3892ead75a74

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results