search

insightsengineering / teal

Exploratory Web Apps for Analyzing Clinical Trial Data
https://insightsengineering.github.io/teal/
Other
168 stars 33 forks source link

Remove `teal::show_rcode_modal` #1154

Closed m7pr closed 2 months ago

m7pr commented 4 months ago

There is an exported show_rcode_modal modal in teal.

However if you seek for the usage of show_rcode_modal inside the whole organization, it only appears in {teal.devel} and design/design_km.Rmd in {teal.modules.hermes}. Search results

I think this modal was replaced by teal.widgets::verbatim_popup_ui(ns("rcode"), button_label = "Show R code"). Search results

m7pr commented 4 months ago

CC @gogonzo @pawelru @donyunardi

pawelru commented 4 months ago

great finding! Definitely to be removed! This is type of things that I wanted to happen in https://github.com/insightsengineering/teal/issues/1007

m7pr commented 2 months ago

@pawelru @gogonzo @donyunardi just double checking. Should we remove this function immediately, or should we follow the deprecation cycle? We could release a version with this function being deprecated, and in 2 months (or whatever is our retention period) release a version of teal with this function being removed.

pawelru commented 2 months ago

I would say the latter - go through the deprecation cycle.

gogonzo commented 2 months ago

@m7pr we go through deprecation process whenever possible. I would deprecate in this case as well

m7pr commented 2 months ago

Coolio