insightsengineering / teal

Exploratory Web Apps for Analyzing Clinical Trial Data
https://insightsengineering.github.io/teal/
Other
168 stars 33 forks source link

503 `$get_html_rvest` method for `TealAppDriver` #1158

Closed m7pr closed 4 months ago

m7pr commented 4 months ago

So instead of app$get_html(selector) %>% rvest::read_html() we can shortly write app$read_html(selector).

github-actions[bot] commented 4 months ago

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/dummy_functions.R                  30       0  100.00%
R/get_rcode_utils.R                  31       1  96.77%   50
R/include_css_js.R                   22       0  100.00%
R/init.R                             86      25  70.93%   108-115, 161-162, 164, 179-185, 192-197, 228
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_filter_manager.R           107      29  72.90%   50-58, 67-72, 195, 200-213
R/module_nested_tabs.R              154       3  98.05%   47, 128, 228
R/module_snapshot_manager.R         209     157  24.88%   87-99, 127-136, 140-152, 154-161, 168-182, 186-188, 190-195, 198-208, 211-227, 236-251, 265-288, 291-302, 305-311, 325, 343-366
R/module_tabs_with_filters.R         76       0  100.00%
R/module_teal_with_splash.R         114       2  98.25%   110, 131
R/module_teal.R                     106       1  99.06%   57
R/modules.R                         153      24  84.31%   127-130, 147-151, 206-210, 292-293, 345, 357-365
R/reporter_previewer_module.R        18       0  100.00%
R/show_rcode_modal.R                 19      19  0.00%    17-36
R/tdata.R                            53       1  98.11%   154
R/teal_data_module-eval_code.R       27       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                  6       0  100.00%
R/teal_reporter.R                    62       5  91.94%   69, 118-119, 122, 139
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      59      12  79.66%   137-150
R/TealAppDriver.R                   195      61  68.72%   66-77, 124-127, 135, 146-147, 155, 167-168, 190-196, 278-325, 369, 402
R/utils.R                           173       1  99.42%   255
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   110-377
R/zzz.R                              11       7  36.36%   3-14
TOTAL                              1862     410  77.98%

Diff against main

Filename             Stmts    Miss  Cover
-----------------  -------  ------  -------
R/TealAppDriver.R       +1       0  +0.16%
TOTAL                   +1       0  +0.01%

Results for commit: 914ea3dce1eb9960165aa010d28a6d2ac56d2cf1

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 4 months ago

Unit Tests Summary

  1 files   25 suites   1m 23s :stopwatch: 224 tests 224 :white_check_mark: 0 :zzz: 0 :x: 462 runs  462 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 914ea3dc.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 4 months ago

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-filter_panel 💚 $19.29$ $-14.00$ $-4$ $0$ $0$ $0$
Additional test case details | Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | shinytest2-filter_panel | 💀 | $6.96$ | $-6.96$ | e2e_filtering_a_module_specific_filter_is_not_refected_in_other_unshared_modules | | shinytest2-filter_panel | 💀 | $6.88$ | $-6.88$ | e2e_filtering_a_module_specific_filter_is_refected_in_other_shared_module | | shinytest2-reporter | 💀 | $2.89$ | $-2.89$ | e2e_reporter_tab_is_created_when_a_module_has_reporter | | shinytest2-reporter | 💀 | $2.82$ | $-2.82$ | e2e_reporter_tab_is_not_created_when_a_module_has_no_reporter | | shinytest2-reporter | 👶 | | $+5.53$ | e2e_reporter_tab_is_only_created_when_a_module_has_reporter |

Results for commit 66843df51247271b8d945d2c7b0c9a12790acc4c

♻️ This comment has been updated with latest results.

m7pr commented 4 months ago

oh geez, I have so many conflicts on this PR after the feature branch that was a base branch got merged to main

vedhav commented 4 months ago

Hey @m7pr I'm rebasing your branch because of this merge. Give me 10 mins.

m7pr commented 4 months ago

@vedhav thanks : P almost cleaned it up locally :D

m7pr commented 4 months ago

Now it contains all the needed changes. Thanks! Ready for the review