Closed kartikeyakirar closed 6 months ago
ignore my previous comment!
Filename Stmts Miss Cover Missing
------------------------------ ------- ------ ------- -------------------------------------------------------------------------------------------------------------------------------
R/dummy_functions.R 30 21 30.00% 21-33, 36-43
R/get_rcode_utils.R 31 1 96.77% 50
R/include_css_js.R 22 0 100.00%
R/init.R 86 31 63.95% 108-115, 161-162, 164, 176-197, 227-228, 230
R/landing_popup_module.R 25 25 0.00% 61-87
R/module_filter_manager.R 107 36 66.36% 37-43, 50-58, 67-72, 195, 200-213
R/module_nested_tabs.R 154 58 62.34% 39-112, 128, 180, 202, 228
R/module_snapshot_manager.R 209 157 24.88% 87-99, 127-136, 140-152, 154-161, 168-182, 186-188, 190-195, 198-208, 211-227, 236-251, 265-288, 291-302, 305-311, 325, 343-366
R/module_tabs_with_filters.R 76 33 56.58% 33-68, 100, 116
R/module_teal_with_splash.R 114 4 96.49% 110, 131, 197-198
R/module_teal.R 106 29 72.64% 57, 68, 77, 150-151, 157, 176-207
R/modules.R 152 26 82.89% 127-130, 147-151, 206-209, 291-292, 344, 356-364, 418-421
R/reporter_previewer_module.R 18 2 88.89% 30, 34
R/show_rcode_modal.R 19 19 0.00% 17-36
R/tdata.R 53 1 98.11% 154
R/teal_data_module-eval_code.R 27 0 100.00%
R/teal_data_module-within.R 7 0 100.00%
R/teal_data_module.R 6 0 100.00%
R/teal_reporter.R 62 5 91.94% 69, 118-119, 122, 139
R/teal_slices-store.R 29 0 100.00%
R/teal_slices.R 59 12 79.66% 137-150
R/TealAppDriver.R 244 244 0.00% 29-506
R/utils.R 173 1 99.42% 255
R/validate_inputs.R 32 0 100.00%
R/validations.R 58 37 36.21% 110-377
R/zzz.R 12 8 33.33% 3-15
TOTAL 1911 750 60.75%
Filename Stmts Miss Cover
----------------- ------- ------ --------
R/TealAppDriver.R +10 +10 +100.00%
TOTAL +10 +10 -0.32%
Results for commit: d8a3352a91e5fe27ac92814997f2d8664f3682b8
Minimum allowed coverage is 80%
:recycle: This comment has been updated with latest results
1 files 28 suites 2m 1s :stopwatch: 234 tests 234 :white_check_mark: 0 :zzz: 0 :x: 497 runs 497 :white_check_mark: 0 :zzz: 0 :x:
Results for commit d8a3352a.
:recycle: This comment has been updated with latest results.
Test Suite | $Status$ | Time on main |
$±Time$ | $±Tests$ | $±Skipped$ | $±Failures$ | $±Errors$ |
---|---|---|---|---|---|---|---|
shinytest2-filter_panel | 💚 | $20.11$ | $-6.72$ | $-2$ | $0$ | $0$ | $+2$ |
Results for commit 767a7c2672eb47530d3da1d40deaa08d9ee87e1d
♻️ This comment has been updated with latest results.
Consider reducing the logic on this wrapper and just passing modified input/output/export and leave the deep checks to the parent method
I like this idea, thanks @averissimo! Do you think we should use self$get_active_module_input(input)
instead of ns(input)?
Also, we need to introduce the self$get_active_module_export
method. WDYT?
~Yes, we should! Great catch~
Following our discussion with @averissimo, it appears that self$get_activemodule... methods are not useful as they return a value that is not being used. However, I have added the rest of the great suggestions here: a2f4392.
This PR introduces a wrapper for the wait_for_value method, specifically designed for output values.