Tests wait for idle by default after setting module input

[averissimo]

Pull Request

Part of https://github.com/insightsengineering/coredev-tasks/issues/503

Changes description

• [feature] Wait for app to be idle by default (skips if wait = FALSE parameter is passed)
• [fix] Removes 5s waiting on every app_driver$click()
  • It was waiting for UI to be stable for 5s, instead of setting the timeout.
  • Current default timeout is set on constructor at 20s

[averissimo]

@vedhav making this a PR instead

[github-actions[bot]]

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  --------------------------------------------------------------------------------------------------------------------------------------------------
R/dummy_functions.R                  36      25  30.56%   21-37, 40-47
R/get_rcode_utils.R                  31       1  96.77%   50
R/include_css_js.R                   22      17  22.73%   12-38, 76-82
R/init.R                             86      31  63.95%   108-115, 161-162, 164, 176-197, 228-229, 231
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_bookmark_manager.R         158     125  20.89%   42-43, 57-59, 70-83, 93-143, 148-149, 189, 224-301
R/module_filter_manager.R            84      19  77.38%   38-42, 157, 162-175
R/module_nested_tabs.R              161      60  62.73%   39-112, 128, 180, 202, 224, 232, 236
R/module_snapshot_manager.R         241     178  26.14%   95-107, 136-139, 143-144, 159-169, 173-188, 190-198, 205-220, 224-228, 230-236, 239-252, 255-273, 282-298, 313-336, 339-350, 353-359, 373, 394-418
R/module_tabs_with_filters.R         76      33  56.58%   33-68, 100, 116
R/module_teal_with_splash.R         114      34  70.18%   60-95, 110, 131, 197-198
R/module_teal.R                     110      76  30.91%   52-119, 150-151, 157, 168, 181-212
R/module_wunder_bar.R                60      39  35.00%   23-41, 55-64, 68-77
R/modules.R                         159      26  83.65%   127-130, 147-151, 206-209, 291-292, 344, 356-364, 418-421
R/reporter_previewer_module.R        19       2  89.47%   30, 34
R/show_rcode_modal.R                 19      19  0.00%    17-36
R/tdata.R                            53       1  98.11%   154
R/teal_data_module-eval_code.R       27       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                  6       0  100.00%
R/teal_reporter.R                    62       5  91.94%   69, 118-119, 122, 139
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      59      12  79.66%   137-150
R/TealAppDriver.R                   273     273  0.00%    43-578
R/utils.R                           173       1  99.42%   255
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   110-377
R/zzz.R                              12       8  33.33%   3-15
TOTAL                              2192    1047  52.24%

Diff against main

Filename             Stmts    Miss  Cover
-----------------  -------  ------  --------
R/TealAppDriver.R       +2      +2  +100.00%
TOTAL                   +2      +2  -0.05%

Results for commit: ae35674de04aae204108209821d415fc3d55c726

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

[github-actions[bot]]

Unit Tests Summary

  1 files   30 suites   2m 53s :stopwatch: 240 tests 240 :white_check_mark: 0 :zzz: 0 :x: 505 runs  505 :white_check_mark: 0 :zzz: 0 :x:

Results for commit ae35674d.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
shinytest2-init	💚	$15.23$	$-4.41$	$0$	$0$	$0$	$0$
shinytest2-landing_popup	💚	$23.13$	$-4.88$	$0$	$0$	$0$	$0$
shinytest2-module_bookmark_manager	💚	$27.10$	$-3.04$	$0$	$0$	$0$	$0$
shinytest2-reporter	💚	$46.29$	$-13.55$	$0$	$0$	$0$	$0$
shinytest2-show-rcode	💚	$8.31$	$-4.44$	$0$	$0$	$0$	$0$
shinytest2-teal_data_module	💚	$24.91$	$-13.50$	$0$	$0$	$0$	$0$
shinytest2-utils	💚	$8.36$	$-4.42$	$0$	$0$	$0$	$0$
shinytest2-wunder_bar	💚	$17.58$	$-8.91$	$0$	$0$	$0$	$0$

Additional test case details

| Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | shinytest2-init | 💚 | $8.55$ | $-4.55$ | e2e_teal_app_initializes_with_sessionInfo_modal | | shinytest2-landing_popup | 💚 | $8.74$ | $-4.82$ | e2e_when_default_landing_popup_module_is_closed_it_shows_the_underlying_teal_app | | shinytest2-module_bookmark_manager | 💚 | $10.60$ | $-4.12$ | bookmark_manager_button_shows_modal_with_url_containing_state_id_when_clicked | | shinytest2-reporter | 💚 | $39.69$ | $-13.65$ | e2e_adding_a_report_card_in_a_module_adds_it_in_the_report_previewer_tab | | shinytest2-show-rcode | 💚 | $8.32$ | $-4.44$ | e2e_teal_app_initializes_with_Show_R_Code_modal | | shinytest2-teal_data_module | 💚 | $8.99$ | $-4.77$ | e2e_teal_data_module_inputs_change_teal_data_object_that_is_passed_to_teal_main_UI | | shinytest2-teal_data_module | 💚 | $7.32$ | $-4.24$ | e2e_teal_data_module_shows_validation_errors | | shinytest2-teal_data_module | 💚 | $8.59$ | $-4.48$ | e2e_teal_data_module_will_have_a_delayed_load_of_datasets | | shinytest2-utils | 💚 | $8.36$ | $-4.42$ | e2e_show_hide_hamburger_works_as_expected | | shinytest2-wunder_bar | 💚 | $8.75$ | $-4.39$ | wunder_bar_srv_clicking_filter_icon_opens_filter_manager_modal | | shinytest2-wunder_bar | 💚 | $8.83$ | $-4.51$ | wunder_bar_srv_clicking_snapshot_icon_opens_snapshot_manager_modal |

Results for commit 975252c9951a53c1177b2af9a684d213b7f2e016

♻️ This comment has been updated with latest results.