insightsengineering / teal

Exploratory Web Apps for Analyzing Clinical Trial Data
https://insightsengineering.github.io/teal/
Other
167 stars 32 forks source link

1154 deprecation for `show_rcode_modal` #1217

Closed m7pr closed 1 month ago

m7pr commented 1 month ago

Close #1154

github-actions[bot] commented 1 month ago

Unit Tests Summary

  1 files   30 suites   2m 51s :stopwatch: 240 tests 240 :white_check_mark: 0 :zzz: 0 :x: 505 runs  505 :white_check_mark: 0 :zzz: 0 :x:

Results for commit df992b09.

:recycle: This comment has been updated with latest results.

m7pr commented 1 month ago

For init.js I created https://github.com/insightsengineering/teal/issues/1218

gogonzo commented 1 month ago

For init.js I created #1218

Sorry my bad, init.js should be removed after hard deprecation. Not now

m7pr commented 1 month ago

recheck

m7pr commented 1 month ago

init.js should be removed after hard deprecation. Not now

Yes, that was clear!

github-actions[bot] commented 1 month ago

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  --------------------------------------------------------------------------------------------------------------------------------------------------
R/TealAppDriver.R                   311     311  0.00%    43-647
R/dummy_functions.R                  36      25  30.56%   21-37, 40-47
R/get_rcode_utils.R                  31       1  96.77%   50
R/include_css_js.R                   22      17  22.73%   12-38, 76-82
R/init.R                             86      31  63.95%   108-115, 161-162, 164, 176-197, 228-229, 231
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_bookmark_manager.R         158     125  20.89%   42-43, 57-59, 70-83, 93-143, 148-149, 189, 224-301
R/module_filter_manager.R            84      19  77.38%   38-42, 157, 162-175
R/module_nested_tabs.R              161      60  62.73%   39-112, 128, 180, 202, 224, 232, 236
R/module_snapshot_manager.R         241     178  26.14%   95-107, 136-139, 143-144, 159-169, 173-188, 190-198, 205-220, 224-228, 230-236, 239-252, 255-273, 282-298, 313-336, 339-350, 353-359, 373, 394-418
R/module_tabs_with_filters.R         76      33  56.58%   33-68, 100, 116
R/module_teal.R                     113      79  30.09%   52-119, 150-151, 157-160, 171, 184-215
R/module_teal_with_splash.R         114      34  70.18%   60-95, 110, 131, 197-198
R/module_wunder_bar.R                60      39  35.00%   23-41, 55-64, 68-77
R/modules.R                         159      26  83.65%   127-130, 147-151, 206-209, 291-292, 344, 356-364, 418-421
R/reporter_previewer_module.R        19       2  89.47%   30, 34
R/show_rcode_modal.R                 24      24  0.00%    17-42
R/tdata.R                            53       1  98.11%   154
R/teal_data_module-eval_code.R       27       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                  6       0  100.00%
R/teal_reporter.R                    68       6  91.18%   69, 77, 125-126, 129, 146
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      59      12  79.66%   137-150
R/utils.R                           173       1  99.42%   255
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   110-377
R/zzz.R                              12       8  33.33%   3-15
TOTAL                              2244    1094  51.25%

Diff against main

Filename                Stmts    Miss  Cover
--------------------  -------  ------  --------
R/show_rcode_modal.R       +5      +5  +100.00%
TOTAL                      +5      +5  -0.11%

Results for commit: df992b09b68c27e1416b59476c7a335d1830c9a9

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 1 month ago

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_tabs_with_filters 👶 $+0.98$ $+8$ $0$ $0$ $0$
shinytest2-landing_popup 💔 $17.55$ $+1.07$ $0$ $0$ $0$ $0$
Additional test case details | Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | module_nested_tabs | 💀 | $0.01$ | $-0.01$ | _unnamed_ | | module_tabs_with_filters | 👶 | | $+0.31$ | active_datanames_returns_dataname_from_active_tab_after_change | | module_tabs_with_filters | 👶 | | $+0.23$ | active_datanames_returns_dataname_from_single_tab | | module_tabs_with_filters | 👶 | | $+0.40$ | active_module_returns_module_specs_from_active_tab_when_filter.module_specific_FALSE | | module_tabs_with_filters | 👶 | | $+0.04$ | srv_tabs_with_filters_throws_error_if_reporter_is_not_of_class_Reporter |

Results for commit 87bcaff8b7692c8d46508b2da6cabdb5411acc18

♻️ This comment has been updated with latest results.