[Question]: button styles

[chlebowa]

What is your question?

There are plenty of buttons in a teal app. Some of them react to theme changes, while others maintain their style regardless of theme.

These buttons can be themed:

• reporter buttons; button elements created with shiny::tags$button
• buttons in the snapshot manager; a elements created with actionLink

These buttons cannot be themed:

• buttons in the teal navbar (the filter hamburger and wunder bar buttons); button elements created with shiny::tags$button
• buttons in the output from teal.widgets; button elements created with shinyWidgets::dropdownButton and shiny::actionButton

All of this causes something of a style inconsistency.

QUESTION

Is this deliberate? If not, are there plans to unify this? If so, in which direction?

Code of Conduct

• [X] I agree to follow this project's Code of Conduct.

Contribution Guidelines

• [X] I agree to follow this project's Contribution Guidelines.

Security Policy

• [X] I agree to follow this project's Security Policy.

[donyunardi]

I think the button should react to theme changes. I don't believe this is intentional, so let's plan to address it.

First, we need to identify which elements are not reacting to theme changes and find out why (e.g., is it the way we coded it?). Then, we can implement the necessary changes.

What do you think?

[donyunardi]

Also, maybe this is a duplicate of https://github.com/insightsengineering/teal/issues/1233?

[chlebowa]

First, we need to identify which elements are not reacting to theme changes and find out why (e.g., is it the way we coded it?). Then, we can implement the necessary changes.

What do you think?

Sounds good to me 👍 I identified two groups but there might be more buried in some modules, I guess.

Also, maybe this is a duplicate of #1233?

I don't believe so.