search

insightsengineering / teal

Exploratory Web Apps for Analyzing Clinical Trial Data
https://insightsengineering.github.io/teal/
Other
167 stars 32 forks source link

Make `progress` argument optional for all modified functions #1243

Closed m7pr closed 3 weeks ago

m7pr commented 3 weeks ago

Initially stated in here https://github.com/insightsengineering/teal/pull/1236#issuecomment-2160469324

[Can I ask to] make progress argument optional for all modified functions? The rationale here is simplicity - we would like to keep the requirements to run the funcs to the meaningful minimum which is in these case: id, modules and datasets. If you look at the functions definitions all the other arguments (incl. filter which is also quite important) has some defaults. In case of progress this could be NULL and if it's Progress we will increment it. Another benefits are in testing - no need to create a dummy progress object to execute functions.

(*) I know the is.missing() stuff but IMHO having x = NULL in the function definition exposes this better without reading docs or function body

pawelru commented 3 weeks ago

done in https://github.com/insightsengineering/teal/pull/1241

m7pr commented 3 weeks ago

Lol, sorry

On Thu, Jun 13, 2024 at 1:52 PM Pawel Rucki @.***> wrote:

done in #1241 https://github.com/insightsengineering/teal/pull/1241

— Reply to this email directly, view it on GitHub https://github.com/insightsengineering/teal/issues/1243#issuecomment-2165437196, or unsubscribe https://github.com/notifications/unsubscribe-auth/A74AIEOFDUUG5D7VF45O73DZHGBYVAVCNFSM6AAAAABJIGDIS2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRVGQZTOMJZGY . You are receiving this because you authored the thread.Message ID: @.***>