insightsengineering / thevalidatoR

Github Action that generates R Package Validation documentation 🏁
https://github.com/marketplace/actions/r-package-validation-report
MIT License
57 stars 5 forks source link

the template is not copied over #20

Closed epijim closed 2 years ago

epijim commented 2 years ago

When you run the gh-action, you get the error:

image

I think it might be because the line below puts into /. I can't remember exactly what I was doing, but I remember running pwd at one point, and pretty sure it was somewhere like /workspace/ that was 'root' in terms of where you enter the container. https://github.com/insightsengineering/thevalidatoR/blob/main/Dockerfile#L11

epijim commented 2 years ago

ahh - yeah, I think this is it: image

so the dockerfile should dump it at /github/workspace/

epijim commented 2 years ago

hmm this didn't work: reverting it back to the original

image

epijim commented 2 years ago

hmm - so the local directory to the R script is /github/workspace so not sure why the copy didn't work :(

image

@dinakar29 - this might need your expertise, as the last comment not working has me stumped on what to try next..

UNLESS... the rmarkdown file also has a different workspace..

cicdguy commented 2 years ago

/github/workspace/, (aka $GITHUB_WORKSPACE || ${{ github.workspace }}) is mounted at CI runtime during CI run either to the container or the VM, depending on where the workflow is being run and is not inherently part of the image being used (if the workflow is being run in a container).

I believe this can be solved by simply copying the template in the workhorse script for the action. Let me try that.

epijim commented 2 years ago

I still get the same error :(

epijim commented 2 years ago

oh wait - maybe I don't :) will try again

epijim commented 2 years ago

Yeah - I don;t think it's working: https://github.com/insightsengineering/rbmi/runs/3870564444?check_suite_focus=true

cicdguy commented 2 years ago

Resolved this: https://github.com/insightsengineering/rbmi/runs/3875207626

cicdguy commented 2 years ago

Associated PR with this fix: https://github.com/insightsengineering/thevalidatoR/pull/25

epijim commented 2 years ago

thanks!