search

insightsengineering / thevalidatoR

Github Action that generates R Package Validation documentation 🏁
https://github.com/marketplace/actions/r-package-validation-report
MIT License
57 stars 5 forks source link

Convert action to composite #45

Closed knightdave closed 2 years ago

knightdave commented 2 years ago

Convert to composite action. Close https://github.com/insightsengineering/thevalidatoR/issues/29.

knightdave commented 2 years ago

Finally tmgr caching working:

No cache: Screenshot 2021-11-24 at 16 31 49

With cache: Screenshot 2021-11-24 at 16 37 22

(aragog 7m --> 2m decreased time)

knightdave commented 2 years ago

@dinakar29 - do you want me to add something more? Is it OK to merge?

cicdguy commented 2 years ago

@dinakar29 - do you want me to add something more? Is it OK to merge?

Can we add this? https://github.com/insightsengineering/thevalidatoR/pull/45#discussion_r756155629

Also, let's merge this after https://github.com/insightsengineering/rbmi/pull/264 has been merged.

knightdave commented 2 years ago

Can we add this? #45 (comment)

I added additional_tlmgr_packages parameter and just right now updated tests.

I'll wait then for your PR.

cicdguy commented 2 years ago

Merging this. Will release this as v1.1