Closed edelarua closed 1 month ago
Hi @qiliu1013,
After your refactor of ADAB in random.cdisc.data
, the "treatment emergent status" data is no longer present in adab
(see change here), and the ATACHAR
variable is no longer present in adab
(see change here). Consequently, the "Characterization Results", "Patient Treatment Emergent ADA Status", and "Patient Treatment Emergent NAb Status" columns can no longer be derived in this listing. How should we proceed?
I have commented out the broken parts of the code to create the listing for now, which generates ADAL01 without the four missing columns until this is fixed.
Hi @qiliu1013,
After your refactor of ADAB in
random.cdisc.data
, the "treatment emergent status" data is no longer present inadab
(see change here), and theATACHAR
variable is no longer present inadab
(see change here). Consequently, the "Characterization Results", "Patient Treatment Emergent ADA Status", and "Patient Treatment Emergent NAb Status" columns can no longer be derived in this listing. How should we proceed?I have commented out the broken parts of the code to create the listing for now, which generates ADAL01 without the four missing columns until this is fixed.
I will be out of office for the upcoming week but if you have any questions please feel free to reach out to anyone on the SME team!
Hi @edelarua, no need to show "Characterization Results" and "Patient Treatment Emergent NAb Status" in the ADAL01. A the new standard specs, there were move into PARAM now. We don't need to consider them. "Patient Treatment Emergent ADA Status" now was in PARAMCD = "ADASTAT1".
Did I answer all your questions?
Thanks, Qi
Did I answer all your questions?
To confirm - "Patient Treatment Emergent ADA Status" also no longer need to be considered, correct? If so then yes you answered all my questions, and the template should be ready for review! Thanks Qi!!
Did I answer all your questions?
To confirm - "Patient Treatment Emergent ADA Status" also no longer need to be considered, correct? If so then yes you answered all my questions, and the template should be ready for review! Thanks Qi!!
Sorry. Patient Treatment Emergent ADA Status is PARAMCD = "ADASTAT1". No need to consider "Patient Treatment Emergent NAb Status"
340 tests 252 :white_check_mark: 59s :stopwatch: 135 suites 88 :zzz: 1 files 0 :x:
Results for commit c34f2825.
:recycle: This comment has been updated with latest results.
Hi @edelarua, can you please share the output with me? Thanks!
hi @qiliu1013 , can you review the output at https://github.com/insightsengineering/tlg-catalog/pull/116/files#diff-800dcce08155543ad547403b286591745b8c15d6d35a7b4fec7dc33a51da067c please
@qiliu1013 see a screenshot of the TLG-C output here:
blocking this for the moment. It seems we need some refactoring in the rcd data again.
@shajoezhu and @edelarua, can you please let me know where to find the latest adal01 code? I didn't see it under 37_adal01 branch. Thanks!
🎉 Thank you for your contribution! Before this PR can be accepted, we require that you all read and agree to our Contributor License Agreement.
You can digitally sign the CLA by posting a comment on this Pull Request in the format shown below. This agreement will apply to this PR as well as all future contributions on this repository.
I have read the CLA Document and I hereby sign the CLA
3 out of 4 committers have signed the CLA.
:white_check_mark: (edelarua)[https://github.com/edelarua]
:white_check_mark: (Melkiades)[https://github.com/Melkiades]
:white_check_mark: (shajoezhu)[https://github.com/shajoezhu]
:x: @Qi Liu
Qi Liu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.
I have read the CLA Document and I hereby sign the CLA
I have read the CLA Document and I hereby sign the CLA
hi @edelarua , could you update the snapshot, once https://github.com/insightsengineering/random.cdisc.data/pull/317 is in please. Thanks!
this is potentially blocked by https://github.com/insightsengineering/random.cdisc.data/issues/319
Snapshot has been updated.
blocked by #270
Results for commit b4daf09c5dbb35503ff3410c9683764faf721e97
♻️ This comment has been updated with latest results.
Work from https://github.com/insightsengineering/tlg-catalog/pull/38 moved here due to repo restructuring since previous PR was created.
Closes #37