insightsengineering / tlg-catalog

A catalog of Tables, Listings and Graphs (TLGs) created with NEST R packages
https://insightsengineering.github.io/tlg-catalog/
Other
20 stars 8 forks source link

updated tm_g_ipp tm_t_shift_by_arm #201

Closed shajoezhu closed 9 months ago

shajoezhu commented 9 months ago

close #198

shajoezhu commented 9 months ago

after discussion, we decided to have tmc's tern version to be >= 0.9.3, and hope this will work. @walkowif @cicdguy fyi, I will deal with CRAN's backwards failure check next time when I submitting tern, and inform that there will be a tmc rerelease to accommodate with the next tern release.

github-actions[bot] commented 9 months ago

Unit Tests Summary

  1 files  2 suites   59s :stopwatch:  24 tests 0 :white_check_mark:  24 :zzz: 0 :x: 289 runs  0 :white_check_mark: 289 :zzz: 0 :x:

Results for commit fa0faa5e.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 9 months ago

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
graph-snaps 💔 $7.84$ $+1.93$ $0$ $0$ $0$ $0$
Additional test case details | Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | graph-snaps | 💔 | $3.50$ | $+1.30$ | plot_v1 |

Results for commit 856eca1cb728db827647982db5dded7c5f0a3931

♻️ This comment has been updated with latest results.

cicdguy commented 9 months ago

after discussion, we decided to have tmc's tern version to be >= 0.9.3, and hope this will work. @walkowif @cicdguy fyi, I will deal with CRAN's backwards failure check next time when I submitting tern, and inform that there will be a tmc rerelease to accommodate with the next tern release.

Sounds good. Thank you @shajoezhu!