Closed edelarua closed 3 months ago
340 tests 252 :white_check_mark: 59s :stopwatch: 135 suites 88 :zzz: 1 files 0 :x:
Results for commit 5ad6e526.
:recycle: This comment has been updated with latest results.
Results for commit 639e51fcf351bd9d9afae139c592ad864efdac66
♻️ This comment has been updated with latest results.
Hi @shajoezhu,
The integration tests for tlg-catalog test the stable version of the package but using the latest versions of the package dependencies so are not in sync with the stable version tested on GitHub via R CMD Check. Because of this, the current version of tlg-catalog is passing the checks on GitHub but not the integration tests, and if this PR is merged in integration tests will pass but the GitHub checks will fail.
Is it possible to change the integration tests to match the GH checks so that both can pass? If not, we should probably leave the integration tests failing until the next release of rtables so the catalog does not break.
Hi @edelarua I think we should follow the order that package test pass first, before considering integration test. so I am inclined to hold this one off a bit longer. what do you think? FYI @pawelru
The integration tests for tlg-catalog test the stable version of the package but using the latest versions of the package dependencies
This feels to me like an error in the test setup. Let's feedback this to IDR team and see what can be done.
The mismatch has been fixed by changing integration tests to use the devel version, so tests should be passing now.
Closes #262