insightsengineering / tlg-catalog

A catalog of Tables, Listings and Graphs (TLGs) created with NEST R packages
https://insightsengineering.github.io/tlg-catalog/
Other
20 stars 8 forks source link

Replicate the snapshot tests for all the articles #75

Closed vedhav closed 1 year ago

vedhav commented 1 year ago

Closes #74

vedhav commented 1 year ago

The forest plots that use grid::grid.draw(p) to plot do not create the snapshots. This affects these couple of documents:

  1. graphs/other/fstg01.qmd
  2. graphs/other/fstg02.qmd
vedhav commented 1 year ago

The error logs do not clearly show where the errors occurred for the graph snapshots so improvements to logs would be beneficial. However, on reviewing the snapshot changes it can be spotted. The markdown snapshots are easy to debug as it shows the variant where the error occurred which is the quarto document name.

vedhav commented 1 year ago

Thanks @vedhav for your work. I need to ask you though to split this pr in at least 5 different ones because chrome is eating up all my cache when I try to see it (I might try gitkraken) but It is still better for me for commenting. Can I ask you also to make an initial PR with only the structural changes with a couple of tables only? i.e. the one about file naming and utils files, so I can discern those from just snapshots PRs.

Sorry for the bothering question, but I think we can be more efficient this way ;)

Sure Davide I will split them for you on Monday. Since I took a long time with this and Paweł is on vacation now I was going to ask for your review on this but it's nice to see that you're already having a look at this :)

vedhav commented 1 year ago

Closing this PR in favor of smaller PRs which are easy to review and make changes. Please follow these twelve PRs: #77, #78, #79, #80, #81, #82, #83, #84, #85, #89, #87, and #88

@Melkiades This is the structure of the PRs: