insightsengineering / verdepcheck

An R package that tests your R package against the min/max versions of specified dependencies
https://insightsengineering.github.io/verdepcheck/
Other
6 stars 0 forks source link

Remotes cleanup refactoring, code cleanup & bug fixing #28

Closed averissimo closed 1 year ago

averissimo commented 1 year ago

Overview of changes description

note: I've added some comments in the code below for additional context.

github-actions[bot] commented 1 year ago

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ------------------------
R/check.R                            37      37  0.00%    26-170
R/deps_installation_proposal.R      137     137  0.00%    58-267
R/desc_utils.R                       70      42  40.00%   15-32, 108, 117-167, 185
R/get_ref.R                         208     207  0.48%    13-419, 435-454
R/solve.R                            81      81  0.00%    9-165
R/utils.R                            70      55  21.43%   3-20, 36-111
TOTAL                               603     559  7.30%

Diff against main

Filename                          Stmts    Miss  Cover
------------------------------  -------  ------  --------
R/check.R                           -36     -36  +100.00%
R/deps_installation_proposal.R      +53     +53  +100.00%
R/desc_utils.R                      +70     +42  +40.00%
R/get_ref.R                        +101    +100  +0.48%
R/solve.R                           +81     +81  +100.00%
R/utils.R                           +70     +55  +21.43%
TOTAL                              +339    +295  +7.30%

Results for commit: 7e9b1449383808610804b0472870d25830bda6ca

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 1 year ago

Unit Tests Summary

  1 files    4 suites   2s :stopwatch: 41 tests 13 :heavy_check_mark: 28 :zzz: 0 :x: 94 runs  65 :heavy_check_mark: 29 :zzz: 0 :x:

Results for commit ecbdc98b.

:recycle: This comment has been updated with latest results.

pawelru commented 1 year ago

This is awesome. Thank you! I have approved this. Let's merge it to the training branch and then the training to the main. I will let you decide when you want to pull the trigger.