insightsengineering / verdepcheck

An R package that tests your R package against the min/max versions of specified dependencies
https://insightsengineering.github.io/verdepcheck/
Other
6 stars 0 forks source link

[Discussion/Question]: what to do when a version doesn't exist on CRAN nor on GitHub tag? #37

Closed averissimo closed 10 months ago

averissimo commented 11 months ago

What is your question?

On strategy: release Should we default to GitHub if version doesn't exist on CRAN / GH tag?

Example

Context, teal.slice last release/tag is 0.4.0. The development main branch is at 0.4.9013

teal's development dependency teal.slice version was changed:

Current outcome:

Possible solution:

  1. Accept this limitation
  2. When version is not found on CRAN, nor on GitHub tags, it uses the latest development version

Code of Conduct

Contribution Guidelines

averissimo commented 11 months ago

(moving discussion from chat to issue @pawelru)

There are some caveats, but I like solution 2. as that's the most effective to avoid bottlenecks.

pawelru commented 11 months ago

For me this is an obvious expected failure (true negative) - testing against released version of dependency fails because development version is required. This gives an important information to a teal maintainer that it cannot be released before releasing teal.slice first. From a different angle: if you decide to vbump any dependency to a devel version it is expected that the release strategy will fail.

When version is not found on CRAN, nor on GitHub tags, it uses the latest development version

If you do this then you are somewhat mixing max and release strategy. In the example you provided: teal maintainer won't be notified that teal cannot be released before releasing teal.slice first.

It's quite clear for me. Please let me know if you need some further explanation. If not - let's close this.