insightsengineering / verdepcheck

An R package that tests your R package against the min/max versions of specified dependencies
https://insightsengineering.github.io/verdepcheck/
Other
6 stars 0 forks source link

include refs for indirect deps #51

Closed pawelru closed 1 month ago

pawelru commented 1 month ago

this fixes the issue observed when testing on teal@479_mirai_pr mirai@main requires dev version of nanonext. We recently added extra_deps parameter to be able to include this in the Imports but we also need to use Config/Needs/verdepcheck entry for these extra dependencies. Right now all additional entries are dropped in get_refs_from_desc(). The change is pretty simple - add extra deps before this function call.

github-actions[bot] commented 1 month ago

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  -------------------------------------------
R/check.R                            73      73  0.00%    27-224
R/deps_installation_proposal.R      143     143  0.00%    62-280
R/desc_utils.R                       96      43  55.21%   15-32, 108, 117-122, 172, 195, 208-247, 265
R/get_ref.R                         239     238  0.42%    13-473, 492-535
R/solve.R                            84      84  0.00%    9-170
R/utils.R                            66      42  36.36%   3-23, 41, 47, 57-104
TOTAL                               701     623  11.13%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 2dc2ed41c6fe857404aacf9e39c701097ebbe470

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 1 month ago

Unit Tests Summary

 1 files   4 suites   2s :stopwatch: 45 tests 15 :white_check_mark: 30 :zzz: 0 :x: 98 runs  67 :white_check_mark: 31 :zzz: 0 :x:

Results for commit 2dc2ed41.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 month ago

Unit Test Performance Difference

Additional test case details | Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | deps_installation_proposal | 👶 | | $+0.03$ | indirect_dependencies_in_the_config_field_ignore_on_default | | deps_installation_proposal | 👶 | | $+0.03$ | indirect_dependencies_in_the_config_field_include_on_match_with_extra_deps_ |

Results for commit 324ef06e1865224bffb4848b582eac11dab9d91c

♻️ This comment has been updated with latest results.