search

insightsengineering / verdepcheck

An R package that tests your R package against the min/max versions of specified dependencies
https://insightsengineering.github.io/verdepcheck/
Other
7 stars 0 forks source link

include CRAN refs in get_ref_max() #53

Closed pawelru closed 2 months ago

pawelru commented 3 months ago

Fix the error observed for max deps check in teal https://github.com/insightsengineering/teal/actions/runs/10262416165/job/28392047028

The root cause is that promises package has higher version on CRAN compared to the GitHub

r$> pkgdepends::parse_pkg_ref("promises") |> get_version()
[1] ‘1.3.0’

r$> pkgdepends::parse_pkg_ref("rstudio/promises") |> get_version()
[1] ‘1.2.1.9001’

I consider this as an edge case but still we need to handle this in the package.

I have modified also get_ref_release() to make it similar to the get_ref_max().

github-actions[bot] commented 3 months ago

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  -------------------------------------------
R/check.R                            73      73  0.00%    27-224
R/deps_installation_proposal.R      143     143  0.00%    62-280
R/desc_utils.R                       96      43  55.21%   15-32, 108, 117-122, 172, 195, 208-247, 265
R/get_ref.R                         244     243  0.41%    13-506, 525-568
R/solve.R                            84      84  0.00%    9-170
R/utils.R                            66      42  36.36%   3-23, 41, 47, 57-104
TOTAL                               706     628  11.05%

Diff against main

Filename       Stmts    Miss  Cover
-----------  -------  ------  -------
R/get_ref.R       +5      +5  -0.01%
TOTAL             +5      +5  -0.08%

Results for commit: 0743c1db594f28d25b237915a49fe62562b5e5aa

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 3 months ago

Unit Tests Summary

 1 files   4 suites   2s :stopwatch: 45 tests 15 :white_check_mark: 30 :zzz: 0 :x: 98 runs  67 :white_check_mark: 31 :zzz: 0 :x:

Results for commit eb951cfb.

github-actions[bot] commented 3 months ago

Unit Tests Summary

 1 files   4 suites   2s :stopwatch: 45 tests 15 :white_check_mark: 30 :zzz: 0 :x: 98 runs  67 :white_check_mark: 31 :zzz: 0 :x:

Results for commit 0743c1db.

:recycle: This comment has been updated with latest results.

pawelru commented 2 months ago

Thanks for good comments. It's indeed better to avoid repetition. I did cherry pick and add some other small enhancements. Feel free to check this out