remove workaround; use devel of pkgcache

insightsengineering / verdepcheck

An R package that tests your R package against the min/max versions of specified dependencies

https://insightsengineering.github.io/verdepcheck/

Other

6 stars 0 forks source link

remove workaround; use devel of pkgcache #54

Closed pawelru closed 2 weeks ago

pawelru commented 4 weeks ago

We have a workaround for a bug that had been fixed on main so let's use this and remove workaround

github-actions[bot] commented 4 weeks ago

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  -------------------------------------------
R/check.R                            73      73  0.00%    27-224
R/deps_installation_proposal.R      143     143  0.00%    62-280
R/desc_utils.R                       96      43  55.21%   15-32, 108, 117-122, 172, 195, 208-247, 265
R/get_ref.R                         244     243  0.41%    13-506, 525-568
R/solve.R                            84      84  0.00%    9-170
R/utils.R                            63      49  22.22%   3-23, 36-100
TOTAL                               703     635  9.67%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  -------
R/utils.R        -3      +7  -14.14%
TOTAL            -3      +7  -1.38%

Results for commit: d501b0a1dbbf80bdecd53d0d99b67706d46db970

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 4 weeks ago

Unit Tests Summary

1 files 4 suites 1s :stopwatch: 45 tests 15 :white_check_mark: 30 :zzz: 0 :x: 98 runs 67 :white_check_mark: 31 :zzz: 0 :x:

Results for commit d501b0a1.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 4 weeks ago

Unit Test Performance Difference

Test Suite	$Status$	Time on `main`	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
utils	💔	$0.66$	$+3.66$	$+1$	$0$	$0$	$0$

Additional test case details

| Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | utils | 💔 | $0.49$ | $+3.67$ | get_ppm_snapshot_by_date_will_accept_NA |

Results for commit 4807ca3012229ce364c3959a76cacdc7be4fdcb9

♻️ This comment has been updated with latest results.

pawelru commented 2 weeks ago

this had been included in https://github.com/insightsengineering/verdepcheck/pull/56