search

insilicomedicine / GENTRL

Generative Tensorial Reinforcement Learning (GENTRL) model
596 stars 215 forks source link

Improved README.md and added Examples #15

Open Bibyutatsu opened 4 years ago

Bibyutatsu commented 4 years ago

Hi insilicomedicine, I have tried updating the Readme file to include more detailed instructions on the installation and running of the model. I have also tried to give some explanation based on my understanding of the model and examples along with some examples of the output images. Please consider this for the community as I have many colleagues and friends who had hard time running your amazing model.

In the future I am thinking of doing these:

  1. Updating the pretrain.ipynb with detailed explanations regarding the steps and significance of the numbers for the different variables.
  2. Trying to explain the train_vaelp() and train_rl() functions in detail.
  3. Add some explanation regarding how to change the gentrl tokenizer and encoder for custom datasets and tokens.

Thank you I hope you consider my request

Bibyutatsu commented 4 years ago

Hi, I have made all the changes. Please review it.

Bibyutatsu commented 4 years ago

Hi, Can you please review my changes and merge the pull request.

gilnahmias commented 4 years ago

Note a missing comma at setup.py, line 14 as per https://youtu.be/ya3AdrfKYzc?t=2470