insin / control-panel-for-twitter

Browser extension which gives you more control over your Twitter timeline and adds missing features and UI improvements - available for desktop and mobile browsers
https://jbscript.dev/control-panel-for-twitter
MIT License
1.92k stars 62 forks source link

Weird Banner Image on Timeline #646

Open AnAngryRaven opened 1 month ago

AnAngryRaven commented 1 month ago

It seems like there's some sort of new Grok advertisement that sometimes appears when you go onto your main home timeline, though I can't be for 100% sure. The reason I say this is because text elements for it are removed, but an image remains:

image

The only reason I even suspect this is a Grok advertisement is looking within the HTML of the page, where it's labelled as such:

image

The problem is that every time I disable the extension and reload the page, it disappears! So not only am I not sure what it is to begin with, I can't even confirm if it's actually even this extension that causes it..

If it turns out not to be related to this extension, my sincere apologies.. I've been trying to find a way to reliably reproduce this, but I'm genuinely not sure what causes it 😞

AnAngryRaven commented 1 month ago

Finally managed to get it to show up with the extension disabled, so it does seem to be this extension that causes it!

(Not sure if the below image is needed, but I've added it for reference just in case) image

insin commented 1 month ago

As you've found out, the hard part is getting it to display again so you can test hiding it 🥲

The element we hide to get rid of other inline timeline prompts (data-test-id="inlinePrompt") is inside this variant, so we need to figure out a different selector to target the top-level timeline item in this case.