search

insin / newforms-bootstrap

Components for rendering a newforms Form using Bootstrap 3
http://insin.github.io/newforms-bootstrap/grid.html
Other
48 stars 13 forks source link

Static display & horizontal against 2.0 [odessyscience version] #9

Open catskul opened 9 years ago

catskul commented 9 years ago

I took odessyscience's branch and rebased it on 2.0 and fixed one noticed problem.

catskul commented 9 years ago

Rendered difference: screenshot from 2015-09-29 23 50 02

catskul commented 9 years ago

@seanadkinson any idea why this test might fail/ render the test seen above differently?

seanadkinson commented 9 years ago

Hadn't looked at the tests, but it seems like it is rendering extra empty divs.

How did you see the rendered difference? I just see the console output when running npm test.

Might be informative to have bootstrap.css loaded in the rendering, to see if it actually looks correct or not.

catskul commented 9 years ago

@seanadkinson I just put both into an empty html document to check the rendering to see if they were functionally equivalent. I'll try again with bootstrap.css loaded.

catskul commented 9 years ago

With bootstrap loaded they do look equivalent. So I think I can probably change the test to make it pass.

screenshot from 2015-09-30 12 17 26