search

insin / package-config-checker

Checks if your dependencies have package.json files config or an .npmignore for packaging
MIT License
47 stars 3 forks source link

False positive scenario: packages with ineffective packaging config #4

Open insin opened 8 years ago

insin commented 8 years ago

Example: eslint-config-standard has the following.npmignore:

node_modules
  1. node_modules is ignored by default, so .npmignore doesn't really do anything here
  2. The npm package contains a test/ directory, but it's given a green tick because .npmignore exists - having a test/ or tests/ directory should probably always be a negative result (and we should probably have a place to keep a list of prominent repos with module authors who disagree with that :ok_hand:)